Navigation: Remove blobs that look like a loading state (alternate version) #37144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that if we can land #36778, we can inherit the orientation of these items as well. |
|
Size Change: -604 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
jasmussen
changed the title
|
I like the direction of this PR and #37099! This approach, similar to the blobs, looks very lean, although I don't find it obvious that you can click on the whole row to select the navigation as you do in the GIF above. In #37099 I share @annezazu's feedback that the placeholder box might be too empty. Given this, how would it look like if combined this approach with #37099 ? Would it make sense to add the bounding box and navigation icon together with these items or would it be too much? |
|
Thanks for the sanity check!
I do worry that with iconography and the bounding box added to this, we'll end up with a great deal of visual noise that doesn't really look like the end result. It's difficult to find the balance between totally obvious (#36858) and the shipping state where it just blends in too well. I can't help but feel like for this block there really is no middle-ground between the two, and that the real solution here (post-5.9) is to ensure that the navigation block always loads the default menu, with option to swap out with another if it exists. I'll keep thinking, sometimes ideas present themselves at the oddest moment. |
|
Closing this one in favor of #37099. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #36858 which removes the blobs entirely, and to #37099 which has a more generic looking setup state.
As outlined on those other PRs, the gray blobs are problematic in that they look like a loading state, meaning people assume no further action is needed on the navigation block. While there may be opportunities in the future to retire a setup state entirely, that needs some further thought, and in the near term, the balance to find is that of:
In contrast to #37099, this one looks like a row of menu items:
I personally don't really think either of these solutions are ideal, so I consider all three options to be temporary.
How has this been tested?
Please insert an empty navigation block and observe the setup state.
Checklist:
*.native.jsfiles for terms that need renaming or removal).