Remove unused dependencies #38388
Merged
Remove unused dependencies #38388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
requested review from
adamziel,
ajitbohra,
cameronvoell,
draganescu,
ellatrix,
getdave,
kevin940726,
nerrad,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
|
This is great. Thank you for spending time cleaning all those packages. We have ESLint rules in place that ensure all uses dependencies are listed in You need to rebase this branch before we can land it as it looks like several CHANGELOG files have conflicts after one of PRs got merged in the last 13 hours 😅 |
gziolo
approved these changes
Feb 1, 2022
Should be resolved now. I used a script locally to help me find all the unused packages. I'll explore a bit later and try to make it into an action. Would be nice if the CI could pick up unused dependencies. |
That would be lovely if we could include it in this workflow: https://github.com/WordPress/gutenberg/blob/trunk/.github/workflows/static-checks.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that multiple packages have unused dependencies. This PR removes the unused dependencies.
Types of changes
Code Quality
Checklist:
*.native.jsfiles for terms that need renaming or removal).