Fix unexpected dragging triggered on spinner buttons on hover in Safari. #38840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Package] Components
|
Size Change: +39 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
mirka
reviewed
Feb 16, 2022
There was a problem hiding this comment.
Thanks for fixing this!
This fix is working well for me. The only regression I noticed is that we no longer get the ns-resize cursor in Safari when dragging. If there's an easy enough fix we can put in this PR, then great. If not, I'm fine with bumping it to a separate issue because the bug fix is more important.
If you could add a quick changelog entry that would be great 👍
And for the touch-action problem that we're getting new console warnings for, I went ahead and made a new issue (#38865).
aaronrobertshaw
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Thanks for the updates @stokesman 👍
This is working nicely for me. I also noticed the cursor and console warning issues @mirka raised. If those are being addressed separately I don't think they should block this fix.
I can also confirm there is no regression regarding the issue with the BoxControl and holding alt to adjust multiple inputs at once.
Nice work!
|
Thanks for the testing and reviews @mirka and @aaronrobertshaw 🙇 . I would like to address the cursor regression here but I'm finding that to be quite baffling. Both the inline style on the document element and the class on the input element change as expected during the drag gesture but somehow fail to affect the cursor. |
8 tasks
cbravobernal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades react-use-gesture to the latest version (now @use-gesture/react) and uses one of its new features to avoid a Safari bug with number inputs and pointer capture.
Fix #32497 fix #37127
Testing Instructions
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).