Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code owners: Remove users without write access and fix typos #39238

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

ocean90
Copy link
Member

@ocean90 ocean90 commented Mar 6, 2022

Description

The current CODEOWNERS files contains a few errors which you should see when open the file on GitHub.

image

List of errors
Unknown owner on line 11: make sure @coderkevin exists and has write access to the repository
…                      @nerrad @coderkevin
Unknown owner on line 86: make sure @jaymanpandya exists and has write access to the repository
…                   @ajitbohra @jaymanpandya
Unknown owner on line 87: make sure @jaymanpandya exists and has write access to the repository
…                   @ajitbohra @jaymanpandya
Unknown owner on line 88: make sure @jaymanpandya exists and has write access to the repository
…                   @ajitbohra @jaymanpandya
Unknown owner on line 89: make sure @jaymanpandya exists and has write access to the repository
…                   @ajitbohra @jaymanpandya
Unknown owner on line 90: make sure @jaymanpandya exists and has write access to the repository
…                   @ajitbohra @jaymanpandya
Unknown owner on line 91: make sure @jaymanpandya exists and has write access to the repository
…                   @ajitbohra @jaymanpandya
Unknown owner on line 133: make sure @timothybjabocs exists and has write access to the repository
…                              @timothybjabocs @spacedmonkey @oandregal
Unknown owner on line 135: make sure @timothybjabocs exists and has write access to the repository
…                              @timothybjabocs @spacedmonkey @oandregal
Unknown owner on line 136: make sure @timothybjabocs exists and has write access to the repository
…                              @timothybjabocs @spacedmonkey @oandregal
Unknown owner on line 137: make sure @timothybjabocs exists and has write access to the repository
…e-json-gutenberg.php          @timothybjabocs @spacedmonkey @oandregal
Unknown owner on line 138: make sure @timothybjabocs exists and has write access to the repository
…e-json-resolver-gutenberg.php @timothybjabocs @spacedmonkey @oandregal
Unknown owner on line 139: make sure @janw-me exists and has write access to the repository
…                              @janw-me
Unknown owner on line 151: make sure @ghost exists and has write access to the repository
…                              @ghost
Unknown owner on line 152: make sure @ghost exists and has write access to the repository
…                              @ghost
Unknown owner on line 153: make sure @ghost exists and has write access to the repository
…                              @ghost
Unknown owner on line 154: make sure @ghost exists and has write access to the repository
…                              @ghost
Unknown owner on line 155: make sure @ghost exists and has write access to the repository
…                              @ghost
Unknown owner on line 156: make sure @ghost exists and has write access to the repository
…                              @ghost

This PR removes users which seem to no longer have write access and fixes a typo in timothybjacobs. The remaining errors are for the native files which should be unowned. Based on the example (last line) I'm wondering if keeping it empty would be enough too? It seems like that wasn't clear when introduced in #13675.

@ocean90 ocean90 requested a review from gziolo March 6, 2022 12:32
@ocean90 ocean90 added the [Type] Project Management Meta-issues related to project management of Gutenberg label Mar 6, 2022
@Mamaduka Mamaduka requested a review from priethor March 7, 2022 06:00
.github/CODEOWNERS Outdated Show resolved Hide resolved
@gziolo
Copy link
Member

gziolo commented Mar 7, 2022

The remaining errors are for the native files which should be unowned. Based on the example (last line) I'm wondering if keeping it empty would be enough too? It seems like that wasn't clear when introduced in #13675.

Yes, it is very likely that you can just simply leave it empty to avoid having everyone being notified. In the past, it worked differently so we used a random GitHub's bot account that was mentioned on Stackoverflow 😄

@gziolo gziolo merged commit eb9392e into trunk Mar 7, 2022
@gziolo gziolo deleted the fix/codeowners branch March 7, 2022 12:38
@gziolo
Copy link
Member

gziolo commented Mar 7, 2022

Let's see what happens 😅

@github-actions github-actions bot added this to the Gutenberg 12.8 milestone Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants