FSE: Allow themes to opt in to wp-block-styles using theme.json #40097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] Themes
scruffian
commented
Apr 6, 2022
| 'text' => null, | ||
| ), | ||
| 'custom' => null, | ||
| 'defaultBlockStyles' => null, |
There was a problem hiding this comment.
This is the only change. Should I just add this to the array in the construct?
scruffian
commented
Apr 6, 2022
| * One of 'default', 'theme', or 'custom'. Default 'theme'. | ||
| */ | ||
| public function __construct( $theme_json = array(), $origin = 'theme' ) { | ||
| parent::__construct( $theme_json, $origin ); |
There was a problem hiding this comment.
I'm not sure why we don't do this more?
mikachan
reviewed
Apr 8, 2022
Yes good idea. Updated! |
|
We decided that 37255 is not the right approach, so this isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This allows themes to enable the
wp-block-stylestheme support using theme.json rather than callingadd_theme_supportin functions.php.Why?
Themes shouldn't need to use PHP.
How?
I've had to overload a few things inside
WP_Theme_JSON_Gutenberg. I think this stuff might need to be in a 6.1 directory unless this lands soon.Testing Instructions
cc @WordPress/block-themers
Fixes #37255