Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Improvements to Getting Started Guides #40964

Merged
merged 9 commits into from
May 23, 2022

Commits on May 10, 2022

  1. Update with copy from Gutenberg Mobile

    Gutenberg Mobile's readme had some copy in the troubleshooting section that wasn't included in Gutenberg's how-to: https://github.com/wordpress-mobile/gutenberg-mobile/edit/trunk/README.md
    
    This commit fixes that issue by updating Gutenberg's how-to with the latest from Gutenberg Mobile.
    Siobhan Bamber committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a9f42b4 View commit details
    Browse the repository at this point in the history
  2. Tweak wording, update inconsistent capitalisation

    Siobhan Bamber committed May 10, 2022
    Configuration menu
    Copy the full SHA
    306ca14 View commit details
    Browse the repository at this point in the history
  3. Tweaks to copy and formatting

    With this commit, I've tidied up some of the copy, attempting to make the instructions as concise and helpful as possible. I've also set the images to the same width to tidy up the overall look of the document (the images will appear small on mobile devices, but can be tapped on to get the full image).
    Siobhan Bamber committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a5d729a View commit details
    Browse the repository at this point in the history
  4. Set all images to fixed width, for consistency

    Siobhan Bamber committed May 10, 2022
    Configuration menu
    Copy the full SHA
    55c3f9d View commit details
    Browse the repository at this point in the history
  5. Rearrange sections to improve overall flow

    - The "Unit Tests" is moved towards the bottom of the document, so that's it's closer to the instructions for integration tests. the document flows as follows:
    - The steps for installing Xcode are moved under the "iOS" section.
    - The overall flow of the document has been updated to the following: Clone Gutenberg > iOS > Android > Tests
    Siobhan Bamber committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a305f10 View commit details
    Browse the repository at this point in the history
  6. Add details about recommended JDK

    Siobhan Bamber committed May 10, 2022
    Configuration menu
    Copy the full SHA
    61f40aa View commit details
    Browse the repository at this point in the history
  7. Add details about Cocoapods

    Siobhan Bamber committed May 10, 2022
    Configuration menu
    Copy the full SHA
    44ed96f View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Refine instructions for installing Cocoapods

    Siobhan Bamber committed May 16, 2022
    Configuration menu
    Copy the full SHA
    421a1a8 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Note ffi may already be installed

    Some versions of Ruby may not require the `ffi` to be manually installed, which is noted with this commit.
    Siobhan Bamber committed May 17, 2022
    Configuration menu
    Copy the full SHA
    a2dd84e View commit details
    Browse the repository at this point in the history