Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate html block test case to Playwright #41231

Merged
merged 3 commits into from
May 24, 2022
Merged

Migrate html block test case to Playwright #41231

merged 3 commits into from
May 24, 2022

Conversation

pooja-muchandikar
Copy link
Contributor

@pooja-muchandikar pooja-muchandikar commented May 23, 2022

What?

Part of #38851.

Migrate html-test.js to its Playwright version.

Why?

Part of #38851.

How?

See MIGRATION.md for migration steps.

Testing Instructions

Run npm run test-e2e:playwright test/e2e/specs/editor/blocks/html.spec.js

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pooja-muchandikar! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 23, 2022
@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726

The CI seems to be failing but the error is on the test case which I didn't even alter. test/e2e/specs/widgets/customizing-widgets.spec.js

Can you please help me reviewing this PR?

Thanks!

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The error seems to come from a flaky test. I think we can ignore it :)

test/e2e/specs/editor/blocks/html.spec.js Outdated Show resolved Hide resolved
@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726,

The feedbacks are addressed, please take a look.

Thanks!

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you again!

Don't mind me, I'm just adding some nitpicking line breaks 😆.

test/e2e/specs/editor/blocks/html.spec.js Show resolved Hide resolved
test/e2e/specs/editor/blocks/html.spec.js Show resolved Hide resolved
test/e2e/specs/editor/blocks/html.spec.js Outdated Show resolved Hide resolved
@kevin940726
Copy link
Member

Oops, I didn't notice that this is a duplicate of #41127. I think we can still merge this one though, but it'd be nice to check out if the work has already been started by someone next time :)

@pooja-muchandikar
Copy link
Contributor Author

Oh no 😒 sorry I didn't notice that. I had created PR few days back #40843 but unfortunately I had to close it yesterday and create new one.

I will take care of this next time 😐

@kevin940726 kevin940726 merged commit 9f1ca90 into WordPress:trunk May 24, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @pooja-muchandikar! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 13.4 milestone May 24, 2022
@priethor priethor added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants