Highlight today's date in DatePicker #41647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
noisysocks
force-pushed
the
add/highlight-today-in-date-picker
branch
from
14f6149
to
1b67157
Compare
|
Size Change: +55 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Jun 10, 2022
|
|
||
| &:focus { | ||
| box-shadow: inset 0 0 0 var(--wp-admin-border-width-focus) var(--wp-admin-theme-color), inset 0 0 0 #{ $border-width-focus + $border-width } $white; | ||
| outline: 2px solid transparent; // Shown in Windows 10 high contrast mode. | ||
| } | ||
| } | ||
|
|
||
| .CalendarDay__today { |
There was a problem hiding this comment.
that is a strange naming convention compared to other components, but I see it matches rest of this scss file - I guess it will get tidied up when it all moves to emotion :-)
There was a problem hiding this comment.
It's because these classes come from a third party library (react-dates).
|
Would love some quick @WordPress/gutenberg-design feedback on this since I pulled the colour choices out of thin air! |
|
Both the default and the hover states look good to me ✨ |
|
Thanks! |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Highlights which day is today in the date picker.
Why?
I think this makes it easier to schedule posts. For example, it's difficult to schedule a post for "this Saturday" if you don't know what today is.
How?
I made it so a light grey background appears on today's date.
I also made it so that, on hover, we alter the text colour instead of the background. I think this is consistent with other buttons that we have, but happy to do whatever here.
Testing Instructions
Screenshots or screencast