-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lodash: Refactor away from _.isNumber()
#41776
Conversation
Size Change: -1 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
As you mentioned in the PR description, the only edge case here is that isNumber
is also checking if the value
is an instance of the Number
wrapper object, although I don't think that the code ever branched into this edge case — we should be good!
Thanks for the swift review @ciampo! Indeed, as I mentioned in the PR description, we're intentionally not supporting this, as it's not used anywhere and I think we should discourage it anyway because it adds unnecessary indirection. |
What?
Lodash's
isNumber()
is used only a few times in the entire codebase. This PR aims to remove that usage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetch
package haslodash
as a dependency #39495How?
Removing
_.isNumber()
is straightforward in favor of a simpletypeof x === 'number'
.There's one special case that Lodash used to handle, when we use the constructor syntax
new Number( 5 )
, and we're not handling that here. I believe that this makes sense - thenew Number(5)
actually produces a wrapper object, and as an object, it's not really a number. So we intentionally don't support this. We have no usages of this in the codebase and I'd suggest not encouraging it anyway.Testing Instructions
BoxControl
in aGallery
block still works well.