Navigation: Move block CSS to JSON #41898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder whether this PR will fix #41146 |
|
Size Change: +10 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
getdave
force-pushed
the
update/navigation-block-styles
branch
from
b00e802
to
7c7e4f9
Compare
getdave
approved these changes
Jun 24, 2022
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
|
Maybe encapsulated in this post: https://make.wordpress.org/core/?p=98557&preview=true |
|
Thanks @scruffian. Might it be worth adding the #dev-notes tag to that post? |
|
I think this is covered by the dev note here: #34180 (comment) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When themes want to override the hover color of the navigation block, this is not possible using theme.json, because this CSS selector is too strong.
The same is true for
textDecoration.Why?
We need to allow themes to set the hover color and text-decoration of links inside the navigation block using theme.json, so it can be edited by users.
How?
This moves the style rules from the block CSS to JSON.
Testing Instructions
This needs to be tested alongside this PR: #41786
You can test using the Stewart theme, and this PR: Automattic/themes#6121
Without this PR, the link hover colors and text-decoration inside the navigation block are inheriting from the link color and text-decoration
With this PR the link hover colors and text-decoration inside the navigation block use the settings from theme.json
Screenshots or screencast
Before:
After:
@WordPress/block-themers