Writing flow: Esc should enter Nav mode consistently, avoid focus loss when clearing selection #42530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when clearing selection
ellatrix
added
the
[Feature] Writing Flow
|
Size Change: -5 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
I was hoping this would also fix the weird page jump (scroll up) that Introduce distraction free mode has. Alas, following a rebase the problem is still there :( |
|
@draganescu Could you report it separately and ping me? I'll have a look. |
|
@ellatrix the problem is introduced in #41740 and I was hoping it was a trunk bug but it isn't. If you have the space to check out #41740 and:
It only happens in #41740 and I can't say how to start debugging it. When I saw this PR here I had a (lazy) idea that maybe my bug would magically disappear - it didn't 😁 If you do check out #41740 it would help if I get an idea what could happen on hitting ESC and entering nav mode that could make the page jump .. and I can continue from there 👍🏻 |
|
@draganescu I'm not sure. If you comment out |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently Esc only enters Navigation mode when a single block is selected. When multiple are selected, selection is cleared.
This PR makes Esc behaviour more consistent by always entering Navigation mode. When pressing Esc from Navigation mode, selection will be cleared and focus will be returned to the editor wrapper (currently focus is lost).
Why?
Consistency & focus loss.
How?
Testing Instructions
Select a few blocks. Press Esc. You should be in Navigation mode. Press Esc again. Block selection should be cleared and focus should be on the wrapper. Pressing Cmd+A should select all blocks (which confirms focus was not lost).
Screenshots or screencast