Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Author Name: Add missing typography supports #43319

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing text-decoration typography support to the Post Author Name block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing text-decoration typography support.
  • Sets the font size control to display by default matching most other blocks.

Testing Instructions

  1. Edit a post, add a Post Author Name block, and select it.
  2. Check that the text-decoration controls are now available.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Style the Post Author Name block via theme.json to add a text-decoration style.
  6. Confirm the theme.json style applies correctly in the editor and frontend.

Example theme.json snippet.

			"core/post-author-name": {
				"typography": {
					"textDecoration": "line-through"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-17.at.8.36.35.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 17, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 17, 2022
@aaronrobertshaw aaronrobertshaw merged commit f98126c into trunk Aug 18, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-post-author-name branch August 18, 2022 23:58
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants