Lodash: Refactor away from _.times()
#43374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
swissspidy,
ntsekouras,
gziolo,
sgomes,
jorgefilipecosta,
mirka,
aristath,
chad1008,
ciampo and
fabiankaegy
|
Size Change: +25 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
sgomes
approved these changes
Aug 18, 2022
| @@ -24,23 +19,23 @@ function Stars( { rating } ) { | |||
| stars | |||
| ) } | |||
| > | |||
| { times( fullStarCount, ( i ) => ( | |||
| { Array.from( { length: fullStarCount } ).map( ( _, i ) => ( | |||
There was a problem hiding this comment.
Huh. Array.from( { length: n } ) is a new one for me; I usually do Array( n ).fill( 0 ) or so, .fill being there to avoid the empty array issue. I suppose this is more readable. Very interesting.
This will even silently produce an empty array (instead of throwing an exception) for invalid array lengths, such as fractional numbers, thus matching the behaviour of _.times(). Pretty impressive 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.times()usage completely and deprecates the function.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
_.times( x, y )is easily replacible byArray.from( { length: x } ).map( y ).Testing Instructions