Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group block: use a variation picker in the placeholder #43496

Merged
merged 24 commits into from
Nov 15, 2022
Merged

Group block: use a variation picker in the placeholder #43496

merged 24 commits into from
Nov 15, 2022

Commits on Nov 15, 2022

  1. Group block: remove default layout for the group block and use a vari… 

    …ation picker in the placeholder.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    cdacf9e View commit details
    Browse the repository at this point in the history

  2. Updating e2e tests to select default group from group variation place… 

    …holder
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b25f7ea View commit details
    Browse the repository at this point in the history

  3. Adding meaningful aria label to block variation picker 

    Updating e2e tests
Refactoring Group edit.js
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    323545c View commit details
    Browse the repository at this point in the history

  4. Only you..... can make my tests go green....

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    bd309ce View commit details
    Browse the repository at this point in the history

  5. Clicking on block variation skip button

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    85f4018 View commit details
    Browse the repository at this point in the history

  6. Clicking on block variation skip

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    fcde025 View commit details
    Browse the repository at this point in the history

  7. Programmatically creating a group block will not default to the const… 

    …rained layout type. It must be specified.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    a9c623e View commit details
    Browse the repository at this point in the history

  8. Reinstating default "constrained" layout type, but adding an extra ep… 

    …hemeral property to identify blocks that have been inserted.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    5f5d5a5 View commit details
    Browse the repository at this point in the history

  9. Ensure that the inserted block is selected after a Group variation is… 

    … selected.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    4ef0d75 View commit details
    Browse the repository at this point in the history

  10. Removing skip link and update description

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    435c42b View commit details
    Browse the repository at this point in the history

  11. Reinstate skip for now until we can update the e2e tests

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    506162d View commit details
    Browse the repository at this point in the history

  12. Stylising the placeholder icons 

    updating tests
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b5d878d View commit details
    Browse the repository at this point in the history

  13. Adding isDefault to the default props and removing it when a group … 

    …variation is selected.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c6771d6 View commit details
    Browse the repository at this point in the history

  14. Updating tests to account for: 

    - default layout is "constrained" when programmatically inserting a group block
- using createBlock with no attributes passed
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    dbdc9c4 View commit details
    Browse the repository at this point in the history

  15. Creating a custom group block variation picker so we do not have to u… 

    …pdate (and potentially break) the blockvariationpicker component, which is used elsewhere.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ed855ec View commit details
    Browse the repository at this point in the history

  16. Add missing button label. 

    Add class to button.
Fix outline heights for button.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    87aa63e View commit details
    Browse the repository at this point in the history

  17. Update native test fixture 

    Updating design/spacing of placeholder
Hardcoding custom icons
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    5c6cfa6 View commit details
    Browse the repository at this point in the history

  18. Removing the isDefault Group block attribute. It's a fragile soluti… 

    …on to keep track of whether a variation has been selected since it adds a potentially useless attribute.

In this iteration, we'll keep track of whether to show the placeholder via useState in the editor, and, more permanently, whether the block has innerblocks.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    8960635 View commit details
    Browse the repository at this point in the history

  19. Ensure that we select the default group variation in the e2e tests.

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    af0be48 View commit details
    Browse the repository at this point in the history

  20. Creating custom hook for showPlaceholder 

    Testing on the CI whether the changes to CPT are required :)
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c84bf8e View commit details
    Browse the repository at this point in the history

  21. Default selected layout type of Group variation is "constrained"

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    72d227c View commit details
    Browse the repository at this point in the history

  22. Am I pretty enough for you, linter?

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    bdb8515 View commit details
    Browse the repository at this point in the history

  23. Reverted

    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6d8bc19 View commit details
    Browse the repository at this point in the history

  24. Reinstating useEffect so that we can react to changes in the style … 

    …state.
    @ramonjd
    ramonjd committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    4f1fd81 View commit details
    Browse the repository at this point in the history