Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try adding layout support to Cover block. #43504

Closed
wants to merge 1 commit into from
Closed

Try adding layout support to Cover block. #43504

wants to merge 1 commit into from

Conversation

tellthemachines
Copy link
Contributor

What?

Attempted solution to #43140.

Currently isn't working fully for nested blocks (e.g. a Cover within a Group), and missing editor implementation.

Why?

How?

Testing Instructions

  1. Add Cover block to post;
  2. Check that layout options display in sidebar;
  3. Check that other blocks with layout (e.g. Group, Buttons, Navigation) aren't broken.

Screenshots or screencast

@Mamaduka Mamaduka mentioned this pull request Aug 23, 2022
Closed
7 tasks
@marko-srb marko-srb added the [Package] Block library /packages/block-library label Aug 26, 2022
@tellthemachines tellthemachines self-assigned this Sep 28, 2022
@tellthemachines tellthemachines added [Feature] Layout Layout block support, its UI controls, and style output. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Sep 30, 2022
@tellthemachines
Copy link
Contributor Author

tellthemachines commented Sep 30, 2022 •
edited
Loading

Trying out a slightly different approach in #44600 to avoid being dependent on a Core change.

@ramonjd ramonjd mentioned this pull request Oct 17, 2022
Closed
@tellthemachines
Copy link
Contributor Author

Closing in favour of #45326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra will be requested when the pull request is marked ready for review ajitbohra is a code owner

Assignees

@tellthemachines tellthemachines

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Layout Layout block support, its UI controls, and style output. [Package] Block library /packages/block-library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tellthemachines @marko-srb