Group: Fix click-first state #43513
Merged
Group: Fix click-first state #43513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Regression
|
Size Change: -71 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
fix/group-click-state
branch
from
fb21371
to
c96acce
Compare
|
@tellthemachines The tests seem to keep failing here, do you have any insights why that might be? |
|
I see the styles changed don't specifically target Group blocks. Could there be side effects we're not aware of? |
|
Sorry the tests were re-running while I pinged you. They failed again, and it looks like there are a few timeouts that seem flaky, but there was a
Good observation. It does bring the click-state also to the Columns block, like so:
I suppose the code should be moved to the Appender component if we want this, or should we start by scoping it better? I tend to think that it's useful to highlight empty containers with the dashed lines, rather than with the appender. Let me know if you see anything else related (a dashed box where it shouldn't be) |
tellthemachines
force-pushed
the
fix/group-click-state
branch
from
50fbbcc
to
3f96c2b
Compare
There was a problem hiding this comment.
I tend to think that it's useful to highlight empty containers with the dashed lines, rather than with the appender
Agreed, it does look better!
I suppose the code should be moved to the Appender component if we want this, or should we start by scoping it better?
If we want to apply this globally to any empty container with layout, it makes more sense in the Appender, yes. Otherwise, if for some reason the Group block isn't there (or if we ever change the CSS loading logic to only load styles for blocks that exist on the page), the styles won't apply to Column.
I pushed a fix for the inserting blocks tests, because they were failing as a result of this change, and rebased so hopefully the tests all pass now!
jasmussen
force-pushed
the
fix/group-click-state
branch
from
3f96c2b
to
b26ff02
Compare
|
Thank you for fixing the tests! From this point, we can do two things. We can scope the rules to just the group block. Columns then doesn't get the click state. TT2 uses columns for the main index template, it'll look like old times:
Or we can move the code. I rebased and did that in b26ff02. That makes the column keep the click state:
I like the latter. What do you think? |
tellthemachines
approved these changes
Aug 26, 2022
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#40664 added a clickable state for an empty group. Recent architecture changes made that code break, so there isn't a clickable state anymore:
This PR fixes it:
Testing Instructions
Insert an empty group block and verify it has a clickable state.