Fix navigation appender position to prevent obstructing its items #43530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierarce
added
[Block] Navigation
|
Size Change: +30 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
javierarce
changed the title
getdave
requested review from
scruffian,
MaggieCabrera,
getdave and
draganescu
|
This is now on radar to be reviewed. |
getdave
force-pushed
the
try-fix-appender-overlap
branch
from
7dc0b16
to
9c5ef8b
Compare
getdave
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thank you for raising this PR @javierarce and apologies it's taken this long to review 🙇
I tested this and it seemed to work well. It's so much easier to have the appender under your cursor as you build out a Nav.
Screen.Capture.on.2022-11-02.at.12-57-53.mp4
🚢 Ship it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Suggest a fix for #42010.
Closes #42010
How?
This PR removes the absolute position for the appended when it is inside of the navigation block.
Testing Instructions
The aggregator should appear next to the last element, not on top of it.