Global Styles: Remove main content layout padding in preview #43601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Aug 25, 2022
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43572
What?
This PR removes the main content layout padding in the global styles preview.
Why?
In the global style preview, the body tag of the iframe is given various styles that represent the actual style based on the
.editor-styles-wrapperclass. This is the expected behavior, but with respect topadding, it is a factor that destroys the preview style.How?
Reset padding to 0 only in the global style preview panel.
Testing Instructions
styles.spacingproperty oftheme.json:{ "version": 2, "styles": { "spacing": { "padding": { "top": "100px", "right": "var(--wp--preset--spacing--30)", "bottom": "0px", "left": "var(--wp--preset--spacing--30)" } } } }Screenshots or screencast