Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment pagination numbers: add background color #43902

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 6, 2022

What?

Updates the block supports to include background color.
Related: #43245

Why?

To match the settings of the comments pagination next and previous inner blocks.

How?

By updating the block support and documentation.

Testing Instructions

  1. First make sure that your test installation has some comments, and that comment pagination is enabled in the WordPress admin area under Settings, Discussion, "Break comments into pages"
  2. Create or open a post or page template in the site editor and add a comments block.
  3. In the comments block, locate the nested comment pagination numbers block.
  4. Confirm if the block has background color and background gradient settings in the block sidebar. Change the color.
  5. Save and view the front, confirm if the color is applied on the front.

Add the example code below to theme.json under styles.blocks.
Confirm that the color displays correctly in the editor and front, and that the colors can be changed in the block settings sidebar.

"core/comments-pagination-numbers": {
	"color": {
			"background": "green"
	}
}

Continue to test the block's background and gradient color in the global styles sidebar in the site editor.

@carolinan carolinan added [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement. labels Sep 6, 2022
@carolinan carolinan marked this pull request as ready for review September 6, 2022 12:50
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carolinan carolinan merged commit 2a429fe into trunk Sep 23, 2022
@carolinan carolinan deleted the update/comment-number-color branch September 23, 2022 07:33
@github-actions github-actions bot added this to the Gutenberg 14.3 milestone Sep 23, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants