Fix empty color indicator with a custom style #44364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierarce
added
Global Styles
|
Size Change: +8 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
Oh this is good! This has been bugging me for so long. Very nice! |
jasmussen
reviewed
Sep 22, 2022
| @@ -23,7 +23,7 @@ function UnforwardedColorIndicator( | |||
|
|
|||
| return ( | |||
| <span | |||
| className={ classnames( 'component-color-indicator', className ) } | |||
| className={ classnames( 'component-color-indicator', className, !colorValue ? 'is-empty' : undefined ) } | |||
There was a problem hiding this comment.
Do we actually need a classname here? I have an idea.
jasmussen
reviewed
Sep 22, 2022
| @@ -45,10 +45,23 @@ | |||
| margin: $grid-unit-20; | |||
|
|
|||
| .component-color-indicator { | |||
| // Show a diagonal line (crossed out) for empty swatches. | |||
| background: linear-gradient(-45deg, transparent 48%, $gray-300 48%, $gray-300 52%, transparent 52%); | |||
There was a problem hiding this comment.
What if you did this:
background: $white linear-gradient(-45deg, transparent 48%, #ddd 48%, #ddd 52%, transparent 52%)
?
Then perhaps you wouldn't need a pseudo element 🤔
|
Really nice. I left some comments about another path we could take, not sure if it'll work, but it might be simpler if it does. |
|
It totally works, I don't know why I missed the simple solution 🤦♂️ I'll update the code. Thanks, Joen. |
jasmussen
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the empty color indicator style so it looks OK on top of other color indicators:
Testing instructions