Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS: remove redundant parentheses for include/require statements #44544

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 28, 2022

What?

Remove redundant parentheses.

Why?

include[_once] and require[_once] are language constructs, not function calls. The parentheses are not needed and not using them yields a micro-optimizaton of the code.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 28, 2022
@jrfnl jrfnl removed the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 28, 2022
@WordPress WordPress deleted a comment from github-actions bot Sep 28, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jrfnl!

@Mamaduka Mamaduka merged commit 7d99c49 into trunk Oct 3, 2022
@Mamaduka Mamaduka deleted the CS/no-parentheses-for-include-require branch October 3, 2022 14:25
@github-actions github-actions bot added this to the Gutenberg 14.3 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants