Lodash: Remove completely from @wordpress/list-reusable-blocks package
#44567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
sgomes,
aristath,
gziolo,
swissspidy,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: +390 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
Sep 29, 2022
| @@ -1,7 +1,7 @@ | |||
| /** | |||
| * External dependencies | |||
| */ | |||
| import { kebabCase } from 'lodash'; | |||
| import { paramCase as kebabCase } from 'change-case'; | |||
There was a problem hiding this comment.
How do you feel about changing the usages to paramCase, too, eliminating the kebabCase name?
There was a problem hiding this comment.
In my experience, kebabCase is a more common name than paramCase, plus it's already known like that in Gutenberg and in the WP core (see _wp_to_kebab_case(), so I kind of prefer to keep the alias.
There was a problem hiding this comment.
OK, I thought that "kebab case" is a silly name that only Lodash uses, but if Core and others use it too, it's probably more standard than I thought 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
@wordpress/list-reusable-blockspackage, including thelodashdependency altogether. There's just a single usage and it is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing a
_.kebabCase()with its counterpart from thechange-caselibrary that we've been widely using.Testing Instructions
/wp-admin/edit.php?post_type=wp_blockkebab-case).