Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Try fixing link color in some TT2 contexts. #44578

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Navigation: Try fixing link color in some TT2 contexts. #44578

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
840c704
Navigation: Try fixing link color in some TT2 contexts.
jasmussen Sep 29, 2022
4f2dbf9
Add comment.
jasmussen Sep 30, 2022
73d58fb
Update comment.
jasmussen Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/block-library/src/navigation/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ $navigation-icon-size: 24px;
display: block;
}

// This rule needs extra specificity so that it inherits the correct color from its parent.
// Otherwise, a link color set by a parent group can override the value.
// This also fixes an issue where a navigation with an explicitly set color is overridden
// by link colors defined in Global Styles.
.wp-block-navigation-item__content.wp-block-navigation-item__content {
ZebulanStanphill marked this conversation as resolved.
Show resolved Hide resolved
color: inherit;
}

// The following rules provide class based application of user selected text
// decoration via block supports.
&.has-text-decoration-underline .wp-block-navigation-item__content {
Expand Down