Fix control widths for Cover, Search, and Spacer blocks #45329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: -13 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Oct 27, 2022
aaronrobertshaw
deleted the
fix/restricted-width-unit-controls-for-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Fixes restriction of control width for Cover, Search, and Spacer blocks.
Why?
Addresses a visual regression after merging #41860. Whether the controls should have a restricted width or not is a separate discussion. They'll likely be updated once we have the new
SliderUnitControlavailable for use in the sidebar as well.How?
Replaces the inline style setting input width with use of the
__unstableInputWidthprop.Also removes wrapping of a control capable of displaying a label with another base control seemingly only to display a label.
Testing Instructions
Screenshots or screencast