Popover: fix exhaustive-deps warning

[ciampo]

What?

Fix ESLint's react-hooks/exhaustive-deps warnings in the Popover component

Why?

Because #41166

How?

• Extract some expressions that were too complicated for ESLint to parse to separate variables
• Add refs.floating to the hook's list of dependencies. Technically refs.floating is a React Ref, but ESLint is not able to determine it and therefore it throws a warning. After discussing with @jsnajdr , we decided that the best option would be to add refs.floating to the list of dependencies, because:
  • it comes from an external dependency (floating ui), and even if we know it's a ref, technically we're not guaranteed
  • since it is supposed to be a ref, adding it to the list of deps won't cause the hook to re-run more often

Testing Instructions

• Run npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/popover/, make sure there are no warnings flagged
• Smoke test the component in the editor, make sure it works as currently on trunk

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[chad1008]

LGTM 🚀 🚢