Global Style Context: Consider global user styles ready if a theme has none #46073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mamaduka
added
[Priority] High
Mamaduka
commented
Nov 25, 2022
packages/edit-site/src/components/global-styles/global-styles-provider.js
Outdated
Show resolved
Hide resolved
Mamaduka
commented
Nov 25, 2022
packages/edit-site/src/components/global-styles/global-styles-provider.js
Outdated
Show resolved
Hide resolved
Mamaduka
changed the title
|
Size Change: +38 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
Backport to WP Minor Release
|
@youknowriad, let me know if you prefer a different solution here. |
youknowriad
reviewed
Nov 29, 2022
| 'globalStyles', | ||
| _globalStylesId | ||
| ) | ||
| : undefined; |
There was a problem hiding this comment.
Can we instead rely on the "isResolving state" of both these two resolvers to mark it ready (instead of checking active themes).
There was a problem hiding this comment.
I also had that idea; I will test how it works in practice.
There was a problem hiding this comment.
Update the logic to use resolvers 69f0c34.
Mamaduka
force-pushed
the
fix/global-styles-is-ready
branch
from
d8aebdd
to
69f0c34
Compare
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
Mamaduka
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #45862.
Also, see #46054.
Report on trac: https://core.trac.wordpress.org/ticket/57193
PR fixes checks for
isUserConfigReadyand marks the config ready state astruewhen a theme has no global user styles.Why?
The block themes and now themes that use block-based template parts don't strictly require a
theme.jsonfile to access the Site Editor. However, after recent performance improvements aroundtheme.jsonmethods, the global user styles query bails early if a theme doesn't support this file.This caused the global styles
isReadystate to be false for such themes and prevented Site Editor from rendering.How?
I adjusted the
isReadycondition inuseGlobalStylesUserConfigto account for themes that can access Site Editor but don't supporttheme.json.Testing Instructions
theme.jsonfile.