-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove block-editor package APIs proxified through editor package #46108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
Issues or PRs that relate to code quality
Needs Dev Note
Requires a developer note for a major WordPress release cycle
labels
Nov 28, 2022
youknowriad
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
November 28, 2022 09:13
Size Change: -2.72 kB (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Riad!
closing in favor of #60061 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WordPress 5.3, we introduced a block editor package that serves as a generic package to build block editor, as a result a lot of APIs moved from the editor package to the block editor package. A proxy to has been kept in the editor package for backward compatibility.
These proxies were meant to be removed a couple WP versions ago but an extra delay has been given to developers to remove their usage.