Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post editor: iframe for block-based themes #46212

Merged
merged 6 commits into from
Dec 19, 2022

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 30, 2022

What?

Iframes the post editor for block based themes.

Context: #33346.
Previously #21102.

Fixes #20797.
Fixes #21193.
Fixes #6156.

See #25775 for FSE.

  • There would be no admin CSS bleed at all. This is something we’ve been struggling with since the beginning.
  • There would be no need to simulate media queries, which is arguably technically more difficult than using an iframe.
  • Relative units like (r)em and vw/vh just work.
  • For a full site, a theme stylesheet can be just dropped in the editor without any adjustment. I think this is important as it makes the life of theme authors much easier.
  • It's possible to have one selection per window, so one in the admin and one in the content. This is useful for e.g. the link UI where the selection in the content can be kept while the selection is also in an input element (for the URL). Maybe be useful in other cases.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix mentioned this pull request Nov 30, 2022
6 tasks
@github-actions
Copy link

github-actions bot commented Nov 30, 2022

Size Change: +397 B (0%)

Total Size: 1.32 MB

Filename Size Change
build/block-library/index.min.js 198 kB +360 B (0%)
build/edit-post/index.min.js 34.7 kB +37 B (0%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 993 B
build/annotations/index.min.js 2.78 kB
build/api-fetch/index.min.js 2.27 kB
build/autop/index.min.js 2.15 kB
build/blob/index.min.js 487 B
build/block-directory/index.min.js 7.16 kB
build/block-directory/style-rtl.css 1.04 kB
build/block-directory/style.css 1.04 kB
build/block-editor/content-rtl.css 2.71 kB
build/block-editor/content.css 2.71 kB
build/block-editor/default-editor-styles-rtl.css 403 B
build/block-editor/default-editor-styles.css 403 B
build/block-editor/index.min.js 182 kB
build/block-editor/style-rtl.css 14.7 kB
build/block-editor/style.css 14.7 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 90 B
build/block-library/blocks/archives/style.css 90 B
build/block-library/blocks/audio/editor-rtl.css 150 B
build/block-library/blocks/audio/editor.css 150 B
build/block-library/blocks/audio/style-rtl.css 122 B
build/block-library/blocks/audio/style.css 122 B
build/block-library/blocks/audio/theme-rtl.css 138 B
build/block-library/blocks/audio/theme.css 138 B
build/block-library/blocks/avatar/editor-rtl.css 116 B
build/block-library/blocks/avatar/editor.css 116 B
build/block-library/blocks/avatar/style-rtl.css 84 B
build/block-library/blocks/avatar/style.css 84 B
build/block-library/blocks/block/editor-rtl.css 305 B
build/block-library/blocks/block/editor.css 305 B
build/block-library/blocks/button/editor-rtl.css 485 B
build/block-library/blocks/button/editor.css 485 B
build/block-library/blocks/button/style-rtl.css 532 B
build/block-library/blocks/button/style.css 532 B
build/block-library/blocks/buttons/editor-rtl.css 337 B
build/block-library/blocks/buttons/editor.css 337 B
build/block-library/blocks/buttons/style-rtl.css 332 B
build/block-library/blocks/buttons/style.css 332 B
build/block-library/blocks/calendar/style-rtl.css 239 B
build/block-library/blocks/calendar/style.css 239 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 100 B
build/block-library/blocks/categories/style.css 100 B
build/block-library/blocks/code/editor-rtl.css 53 B
build/block-library/blocks/code/editor.css 53 B
build/block-library/blocks/code/style-rtl.css 121 B
build/block-library/blocks/code/style.css 121 B
build/block-library/blocks/code/theme-rtl.css 124 B
build/block-library/blocks/code/theme.css 124 B
build/block-library/blocks/columns/editor-rtl.css 108 B
build/block-library/blocks/columns/editor.css 108 B
build/block-library/blocks/columns/style-rtl.css 406 B
build/block-library/blocks/columns/style.css 406 B
build/block-library/blocks/comment-author-avatar/editor-rtl.css 125 B
build/block-library/blocks/comment-author-avatar/editor.css 125 B
build/block-library/blocks/comment-content/style-rtl.css 92 B
build/block-library/blocks/comment-content/style.css 92 B
build/block-library/blocks/comment-template/style-rtl.css 199 B
build/block-library/blocks/comment-template/style.css 198 B
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 123 B
build/block-library/blocks/comments-pagination-numbers/editor.css 121 B
build/block-library/blocks/comments-pagination/editor-rtl.css 222 B
build/block-library/blocks/comments-pagination/editor.css 209 B
build/block-library/blocks/comments-pagination/style-rtl.css 235 B
build/block-library/blocks/comments-pagination/style.css 231 B
build/block-library/blocks/comments-title/editor-rtl.css 75 B
build/block-library/blocks/comments-title/editor.css 75 B
build/block-library/blocks/comments/editor-rtl.css 840 B
build/block-library/blocks/comments/editor.css 839 B
build/block-library/blocks/comments/style-rtl.css 637 B
build/block-library/blocks/comments/style.css 636 B
build/block-library/blocks/cover/editor-rtl.css 612 B
build/block-library/blocks/cover/editor.css 613 B
build/block-library/blocks/cover/style-rtl.css 1.57 kB
build/block-library/blocks/cover/style.css 1.56 kB
build/block-library/blocks/embed/editor-rtl.css 293 B
build/block-library/blocks/embed/editor.css 293 B
build/block-library/blocks/embed/style-rtl.css 410 B
build/block-library/blocks/embed/style.css 410 B
build/block-library/blocks/embed/theme-rtl.css 138 B
build/block-library/blocks/embed/theme.css 138 B
build/block-library/blocks/file/editor-rtl.css 300 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 253 B
build/block-library/blocks/file/style.css 254 B
build/block-library/blocks/file/view.min.js 353 B
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/gallery/editor-rtl.css 984 B
build/block-library/blocks/gallery/editor.css 988 B
build/block-library/blocks/gallery/style-rtl.css 1.55 kB
build/block-library/blocks/gallery/style.css 1.55 kB
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 654 B
build/block-library/blocks/group/editor.css 654 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 78 B
build/block-library/blocks/group/theme.css 78 B
build/block-library/blocks/heading/style-rtl.css 76 B
build/block-library/blocks/heading/style.css 76 B
build/block-library/blocks/html/editor-rtl.css 332 B
build/block-library/blocks/html/editor.css 333 B
build/block-library/blocks/image/editor-rtl.css 829 B
build/block-library/blocks/image/editor.css 828 B
build/block-library/blocks/image/style-rtl.css 627 B
build/block-library/blocks/image/style.css 630 B
build/block-library/blocks/image/theme-rtl.css 137 B
build/block-library/blocks/image/theme.css 137 B
build/block-library/blocks/latest-comments/style-rtl.css 298 B
build/block-library/blocks/latest-comments/style.css 298 B
build/block-library/blocks/latest-posts/editor-rtl.css 213 B
build/block-library/blocks/latest-posts/editor.css 212 B
build/block-library/blocks/latest-posts/style-rtl.css 478 B
build/block-library/blocks/latest-posts/style.css 478 B
build/block-library/blocks/list/style-rtl.css 88 B
build/block-library/blocks/list/style.css 88 B
build/block-library/blocks/media-text/editor-rtl.css 266 B
build/block-library/blocks/media-text/editor.css 263 B
build/block-library/blocks/media-text/style-rtl.css 507 B
build/block-library/blocks/media-text/style.css 505 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/editor-rtl.css 716 B
build/block-library/blocks/navigation-link/editor.css 715 B
build/block-library/blocks/navigation-link/style-rtl.css 115 B
build/block-library/blocks/navigation-link/style.css 115 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 299 B
build/block-library/blocks/navigation-submenu/editor.css 299 B
build/block-library/blocks/navigation/editor-rtl.css 2.15 kB
build/block-library/blocks/navigation/editor.css 2.16 kB
build/block-library/blocks/navigation/style-rtl.css 2.23 kB
build/block-library/blocks/navigation/style.css 2.21 kB
build/block-library/blocks/navigation/view-modal.min.js 2.81 kB
build/block-library/blocks/navigation/view.min.js 447 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 376 B
build/block-library/blocks/page-list/editor.css 376 B
build/block-library/blocks/page-list/style-rtl.css 175 B
build/block-library/blocks/page-list/style.css 175 B
build/block-library/blocks/paragraph/editor-rtl.css 174 B
build/block-library/blocks/paragraph/editor.css 174 B
build/block-library/blocks/paragraph/style-rtl.css 279 B
build/block-library/blocks/paragraph/style.css 281 B
build/block-library/blocks/post-author/style-rtl.css 175 B
build/block-library/blocks/post-author/style.css 176 B
build/block-library/blocks/post-comments-form/editor-rtl.css 96 B
build/block-library/blocks/post-comments-form/editor.css 96 B
build/block-library/blocks/post-comments-form/style-rtl.css 501 B
build/block-library/blocks/post-comments-form/style.css 501 B
build/block-library/blocks/post-date/style-rtl.css 61 B
build/block-library/blocks/post-date/style.css 61 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-featured-image/editor-rtl.css 586 B
build/block-library/blocks/post-featured-image/editor.css 584 B
build/block-library/blocks/post-featured-image/style-rtl.css 318 B
build/block-library/blocks/post-featured-image/style.css 318 B
build/block-library/blocks/post-navigation-link/style-rtl.css 153 B
build/block-library/blocks/post-navigation-link/style.css 153 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 282 B
build/block-library/blocks/post-template/style.css 282 B
build/block-library/blocks/post-terms/style-rtl.css 96 B
build/block-library/blocks/post-terms/style.css 96 B
build/block-library/blocks/post-title/style-rtl.css 100 B
build/block-library/blocks/post-title/style.css 100 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 135 B
build/block-library/blocks/pullquote/editor.css 135 B
build/block-library/blocks/pullquote/style-rtl.css 326 B
build/block-library/blocks/pullquote/style.css 325 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 221 B
build/block-library/blocks/query-pagination/editor.css 211 B
build/block-library/blocks/query-pagination/style-rtl.css 288 B
build/block-library/blocks/query-pagination/style.css 284 B
build/block-library/blocks/query-title/style-rtl.css 63 B
build/block-library/blocks/query-title/style.css 63 B
build/block-library/blocks/query/editor-rtl.css 440 B
build/block-library/blocks/query/editor.css 440 B
build/block-library/blocks/quote/style-rtl.css 213 B
build/block-library/blocks/quote/style.css 213 B
build/block-library/blocks/quote/theme-rtl.css 223 B
build/block-library/blocks/quote/theme.css 226 B
build/block-library/blocks/read-more/style-rtl.css 132 B
build/block-library/blocks/read-more/style.css 132 B
build/block-library/blocks/rss/editor-rtl.css 202 B
build/block-library/blocks/rss/editor.css 204 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 165 B
build/block-library/blocks/search/editor.css 165 B
build/block-library/blocks/search/style-rtl.css 409 B
build/block-library/blocks/search/style.css 406 B
build/block-library/blocks/search/theme-rtl.css 114 B
build/block-library/blocks/search/theme.css 114 B
build/block-library/blocks/separator/editor-rtl.css 146 B
build/block-library/blocks/separator/editor.css 146 B
build/block-library/blocks/separator/style-rtl.css 234 B
build/block-library/blocks/separator/style.css 234 B
build/block-library/blocks/separator/theme-rtl.css 194 B
build/block-library/blocks/separator/theme.css 194 B
build/block-library/blocks/shortcode/editor-rtl.css 474 B
build/block-library/blocks/shortcode/editor.css 474 B
build/block-library/blocks/site-logo/editor-rtl.css 490 B
build/block-library/blocks/site-logo/editor.css 490 B
build/block-library/blocks/site-logo/style-rtl.css 203 B
build/block-library/blocks/site-logo/style.css 203 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 116 B
build/block-library/blocks/site-title/editor.css 116 B
build/block-library/blocks/site-title/style-rtl.css 57 B
build/block-library/blocks/site-title/style.css 57 B
build/block-library/blocks/social-link/editor-rtl.css 184 B
build/block-library/blocks/social-link/editor.css 184 B
build/block-library/blocks/social-links/editor-rtl.css 674 B
build/block-library/blocks/social-links/editor.css 673 B
build/block-library/blocks/social-links/style-rtl.css 1.4 kB
build/block-library/blocks/social-links/style.css 1.39 kB
build/block-library/blocks/spacer/editor-rtl.css 332 B
build/block-library/blocks/spacer/editor.css 332 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 457 B
build/block-library/blocks/table/editor.css 457 B
build/block-library/blocks/table/style-rtl.css 636 B
build/block-library/blocks/table/style.css 635 B
build/block-library/blocks/table/theme-rtl.css 184 B
build/block-library/blocks/table/theme.css 184 B
build/block-library/blocks/tag-cloud/style-rtl.css 251 B
build/block-library/blocks/tag-cloud/style.css 253 B
build/block-library/blocks/template-part/editor-rtl.css 404 B
build/block-library/blocks/template-part/editor.css 404 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/editor-rtl.css 691 B
build/block-library/blocks/video/editor.css 694 B
build/block-library/blocks/video/style-rtl.css 179 B
build/block-library/blocks/video/style.css 179 B
build/block-library/blocks/video/theme-rtl.css 139 B
build/block-library/blocks/video/theme.css 139 B
build/block-library/classic-rtl.css 162 B
build/block-library/classic.css 162 B
build/block-library/common-rtl.css 1.05 kB
build/block-library/common.css 1.05 kB
build/block-library/editor-elements-rtl.css 75 B
build/block-library/editor-elements.css 75 B
build/block-library/editor-rtl.css 11.7 kB
build/block-library/editor.css 11.7 kB
build/block-library/elements-rtl.css 54 B
build/block-library/elements.css 54 B
build/block-library/reset-rtl.css 478 B
build/block-library/reset.css 478 B
build/block-library/style-rtl.css 12.4 kB
build/block-library/style.css 12.4 kB
build/block-library/theme-rtl.css 716 B
build/block-library/theme.css 721 B
build/block-serialization-default-parser/index.min.js 1.13 kB
build/block-serialization-spec-parser/index.min.js 2.83 kB
build/blocks/index.min.js 50.4 kB
build/components/index.min.js 204 kB
build/components/style-rtl.css 11.6 kB
build/components/style.css 11.6 kB
build/compose/index.min.js 12.3 kB
build/core-data/index.min.js 15.9 kB
build/customize-widgets/index.min.js 11.7 kB
build/customize-widgets/style-rtl.css 1.41 kB
build/customize-widgets/style.css 1.41 kB
build/data-controls/index.min.js 663 B
build/data/index.min.js 8.16 kB
build/date/index.min.js 32.1 kB
build/deprecated/index.min.js 518 B
build/dom-ready/index.min.js 336 B
build/dom/index.min.js 4.71 kB
build/edit-navigation/index.min.js 16.2 kB
build/edit-navigation/style-rtl.css 4.11 kB
build/edit-navigation/style.css 4.12 kB
build/edit-post/classic-rtl.css 571 B
build/edit-post/classic.css 571 B
build/edit-post/style-rtl.css 7.45 kB
build/edit-post/style.css 7.44 kB
build/edit-site/index.min.js 64.8 kB
build/edit-site/style-rtl.css 9.06 kB
build/edit-site/style.css 9.06 kB
build/edit-widgets/index.min.js 16.8 kB
build/edit-widgets/style-rtl.css 4.46 kB
build/edit-widgets/style.css 4.46 kB
build/editor/index.min.js 44.1 kB
build/editor/style-rtl.css 3.69 kB
build/editor/style.css 3.68 kB
build/element/index.min.js 4.72 kB
build/escape-html/index.min.js 548 B
build/experiments/index.min.js 882 B
build/format-library/index.min.js 7.2 kB
build/format-library/style-rtl.css 598 B
build/format-library/style.css 597 B
build/hooks/index.min.js 1.66 kB
build/html-entities/index.min.js 454 B
build/i18n/index.min.js 3.79 kB
build/is-shallow-equal/index.min.js 535 B
build/keyboard-shortcuts/index.min.js 1.79 kB
build/keycodes/index.min.js 1.86 kB
build/list-reusable-blocks/index.min.js 2.13 kB
build/list-reusable-blocks/style-rtl.css 865 B
build/list-reusable-blocks/style.css 865 B
build/media-utils/index.min.js 2.94 kB
build/notices/index.min.js 977 B
build/plugins/index.min.js 1.95 kB
build/preferences-persistence/index.min.js 2.23 kB
build/preferences/index.min.js 1.35 kB
build/primitives/index.min.js 960 B
build/priority-queue/index.min.js 1.59 kB
build/react-i18n/index.min.js 702 B
build/react-refresh-entry/index.min.js 8.44 kB
build/react-refresh-runtime/index.min.js 7.31 kB
build/redux-routine/index.min.js 2.75 kB
build/reusable-blocks/index.min.js 2.26 kB
build/reusable-blocks/style-rtl.css 283 B
build/reusable-blocks/style.css 283 B
build/rich-text/index.min.js 10.7 kB
build/server-side-render/index.min.js 2.09 kB
build/shortcode/index.min.js 1.52 kB
build/style-engine/index.min.js 1.53 kB
build/token-list/index.min.js 650 B
build/url/index.min.js 3.7 kB
build/vendors/inert-polyfill.min.js 2.48 kB
build/vendors/react-dom.min.js 41.8 kB
build/vendors/react.min.js 4.02 kB
build/viewport/index.min.js 1.09 kB
build/warning/index.min.js 280 B
build/widgets/index.min.js 7.27 kB
build/widgets/style-rtl.css 1.21 kB
build/widgets/style.css 1.21 kB
build/wordcount/index.min.js 1.06 kB

compressed-size-action

@ellatrix ellatrix force-pushed the try/iframe-block-based-theme-post-editor branch 4 times, most recently from 87d90e5 to 4178a01 Compare November 30, 2022 22:51
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is a good idea given the accessibility implications of iFrames. Before it is mentioned, yes, it exists in FSE but that doesn't mean it should. iFrames make the whole interaction model for screen readers much harder. I think we should leave the post editor well alone even for block themes.

@glendaviesnz
Copy link
Contributor

I tested the Jetpack map block that had issues when the site editor was first iframed and it works as expected in the iframed post editor so the initial fix implemented for that copies across.

Other blocks that are loading scripts but not using block.json may experience the same issue and potentially haven't been used in the site editor so not aware of framing issues, so a dev note, etc. well ahead of this change might be needed.

@ellatrix
Copy link
Member Author

ellatrix commented Dec 1, 2022

Not sure this is a good idea given the accessibility implications of iFrames. Before it is mentioned, yes, it exists in FSE but that doesn't mean it should. iFrames make the whole interaction model for screen readers much harder. I think we should leave the post editor well alone even for block themes.

@alexstine Could you please elaborate on the issues? I'm sure we can solve them. This has been planned for years now, with a lot of work leading up to it. It's also worth noting that many other editors use iframes, including our classic editor TinyMCE. The customiser also uses an iframe. It doesn't help much to just say that it's not a good idea and that it makes things much harder. Would love to hear specifics so we can improve.

@ellatrix ellatrix added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Dec 1, 2022
@ellatrix
Copy link
Member Author

ellatrix commented Dec 1, 2022

@glendaviesnz Of course, this will for sure get a elaborate Dev Note! 😄

@alexstine
Copy link
Contributor

@ellatrix

  1. Fairly confident classic editor is wrapped in a role="application" so I would not know if it were a frame or not.
  2. iFrames by nature can make things very difficult for screen reader interaction. It is a browser inside a browser essentially and it adds quite a bit of verbosity to screen readers. Extra noise for say as it is reading a whole new document structure.
  3. There is a negative tabindex="-1" on the body tag of the iFrame which is causing focus return from the block toolbar to not work properly. Because the block toolbar does not sit inside the iFrame, focus passes through the body tag causing the screen reader to announce every block in the canvas before announcing the current focus position within a block. In some blocks, such a focus position does not really exist, existing columns block for example.
  4. This needs to wait until all blocks can be reliably focussed. I do not see that happening anytime soon. This is because if you have a columns block inserted last and you shift+tab from the sidebar in to the block, the iFrame is announced due to nothing within the columns block taking focus and interrupting the speech.

Even if the classic editor were wrapped in an iFrame, it would not suffer from the same issues introduced by Gutenberg and therefor, this iFrame is premature for the post editor if there is any hope of not further wrecking UX for screen reader users.

Using other editors as an argument does not apply here. Other editors are either not functionally the same as Gutenberg or suffer from equal accessibility issues.

I cannot say for certain how long ago the planning started for this but my comments would have likely been the same back then.

Do you not find the UX to be worse with Voiceover? I believe Voiceover on Mac requires you to interact with the iFrame as it is seen as a different window. I would bet accessibility with iFrames is probably worse in Mac than Windows.

Thanks.

@alexstine
Copy link
Contributor

It is also worth mentioning that iFrames do some weird things with context menus in Windows. For example, it seems impossible for me to inspect elements in the iFrame so I have to open my inspector outside of the iFrame and navigate down the DOM until I find it. I am sure that would never qualify as a blocker, but it would hurt contributors who are trying to improve the project as it would increase the time it takes to debug locally.

@ellatrix
Copy link
Member Author

ellatrix commented Dec 1, 2022

@alexstine Are these issues reported? If not, could you report them so we can fix them? They must be fixed for FSE, template mode, device previews, all of which are iframed.

@alexstine
Copy link
Contributor

@ellatrix I have no idea TBH. I do not have the bandwidth to really focus on FSE so much of it is quite unknown to me.

@ellatrix ellatrix force-pushed the try/iframe-block-based-theme-post-editor branch from 391c293 to be43ef0 Compare December 1, 2022 19:04
@davidwebca
Copy link

Accessibility issues should be addressed separately and shouldn't be considered as a blocker here.

But just to add details for the sake of discussion, iFrames are well supported by most assistive technologies, their content is parseable just as any other HTML content and WCAG simply recommends setting a title to describe what is happening inside the iframe (we could even eventually decide to update the title dynamically to reflect the block selected inside the iframe ex.: "Block editor. Block number 4 "columns" is currently selected"). It should be ordered very high if not first within the main page to ensure it's quickly available.

They also require bypass blocks which is usually just an anchor to skip focus onto the first selectable element and bypass repeating elements such as navigation. That's why we often seen links "Skip to content" at the top of many themes nowadays.

Most of the issues raised by people about iFrames are due to the lack of control when loading third party websites and such. We, on the other hand, will have full control on the rendering and markup, so we should be able to provide an equally accessible experience as it is right now if not better.

iFraming the block editor has been awaited by developers for years (since the beginning of Gutenberg, really) because it's a major headache to scope the CSS styles appropriately, especially since scoped styles were dropped by major browsers and W3C.

@alexstine
Copy link
Contributor

@davidwebca

Accessibility issues should be addressed separately and shouldn't be considered as a blocker here.

Disagree. Chances of this getting fixed unless it is a blocker is very slim. The project moves too quickly and if these things are active blockers of work that needs to get done, I can get attention on them. Otherwise, it may be a few major releases from now.

Agree with your mention of third-party iFrames, this has generally been true. The flip side to what you say is yes we have control over the content rendered but such fixes actually have to be made. This PR puts the cart before the horse.

@ellatrix
Copy link
Member Author

ellatrix commented Dec 1, 2022

I'll gladly look into any accessibility issues.

This PR puts the cart before the horse.

This makes it sound like these were know issues to solve before this PR. They were not. I don't see any issues related to iframing reported.

iFrames by nature can make things very difficult for screen reader interaction. It is a browser inside a browser essentially and it adds quite a bit of verbosity to screen readers. Extra noise for say as it is reading a whole new document structure.

I'm sure we can reduce this verbosity? Would be great to have reports of what people are experiencing.

There is a negative tabindex="-1" on the body tag of the iFrame which is causing focus return from the block toolbar to not work properly.

I'm not able to reproduce. After which steps does focus return not work properly?

This needs to wait until all blocks can be reliably focussed. I do not see that happening anytime soon. This is because if you have a columns block inserted last and you shift+tab from the sidebar in to the block, the iFrame is announced due to nothing within the columns block taking focus and interrupting the speech.

Is this a bug with the iframe or without as well? I'm trying a columns block at the end of the content and then Shift+Tab from the sidebar and it works fine? Would be good to have steps to reproduce.

@alexstine
Copy link
Contributor

@ellatrix If this blocker is solved, let's re-evaluate the PR after. Might be able to live with some nice to haves later on.

#46258

Thanks.

@alexstine
Copy link
Contributor

Most of why this happens to be such a big issue for me now is due to the fact that FSE is confusing and really hard to use for keyboard users. I have made the choice to focus around the post editor as I have limited time and limited resources to contribute back to the project. I picked the place I thought I could make the most impact. In theory, if I improve the post editor and general components, FSE should slowly get better. However, not being in FSE since my focus is not there, I only start to get involved when parts of FSE start migrating in to the post editor. Hope this clears up my position.

I'll try to open another issue later about the verbosity, but these things are hard to put in words without recordings. Maybe samples from the speech viewer will work out.

@costdev
Copy link
Contributor

costdev commented Dec 1, 2022

Accessibility issues should be addressed separately and shouldn't be considered as a blocker here.

Agree with @alexstine. Isolating accessibility issues is problematic. We wouldn't isolate UX/design/performance and not consider those blockers, and I think what developers want, while important, is significantly less important than what users of assistive technologies want (I say this as a developer who doesn't require assistive technology).

That doesn't diminish the work that has gone into this PR. What it should do, is highlight how problematic accessibility issues are in the project, as they block enhancements like this from moving forward.

Unblocking a blocker is done by solving the problem, not by declassifying it and kicking it down the road.

@alexstine
Copy link
Contributor

Just opened another issue that would be a really big nice to have. I would not call it a blocker but the experience would be better if it was solved.

#46260

@davidwebca
Copy link

We wouldn't isolate UX/design/performance and not consider those blockers

Mmm... we would and we do all the time?

Unblocking a blocker is done by solving the problem, not by declassifying it and kicking it down the road.

Far from what I meant, I apologize if it was received that way.

Regardless, my point was to branch those as separate issues to avoid entangling, and it is happening so that's good, but also to advocate for not blocking, if possible, the iframing progress that has been in the works by Ella for almost 2 years, possibly more. I hope this moves quickly and I'll gladly help testing keyboard tabbability and voiceover.

@ellatrix ellatrix merged commit 967cba4 into trunk Dec 19, 2022
@ellatrix ellatrix deleted the try/iframe-block-based-theme-post-editor branch December 19, 2022 12:45
@github-actions github-actions bot added this to the Gutenberg 14.9 milestone Dec 19, 2022
@alexstine
Copy link
Contributor

@ellatrix Correct, just the verbosity issue. I believe the other issue mentioned is now eliminated.

Thanks.

@mcsf mcsf mentioned this pull request Jan 16, 2023
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Jan 26, 2023
The block editor's iframe needs to know if the theme is a block theme. This changeset adds a setting to `get_block_editor_settings()`.

Reference:
* WordPress/gutenberg#46212

Props ellatrix, alexstine, costdev, dgwyer, glendaviesnz, scruffian.
Fixes #57549.

git-svn-id: https://develop.svn.wordpress.org/trunk@55147 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jan 26, 2023
The block editor's iframe needs to know if the theme is a block theme. This changeset adds a setting to `get_block_editor_settings()`.

Reference:
* WordPress/gutenberg#46212

Props ellatrix, alexstine, costdev, dgwyer, glendaviesnz, scruffian.
Fixes #57549.
Built from https://develop.svn.wordpress.org/trunk@55147


git-svn-id: http://core.svn.wordpress.org/trunk@54680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Jan 26, 2023
The block editor's iframe needs to know if the theme is a block theme. This changeset adds a setting to `get_block_editor_settings()`.

Reference:
* WordPress/gutenberg#46212

Props ellatrix, alexstine, costdev, dgwyer, glendaviesnz, scruffian.
Fixes #57549.
Built from https://develop.svn.wordpress.org/trunk@55147


git-svn-id: https://core.svn.wordpress.org/trunk@54680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dmsnell pushed a commit to dmsnell/wordpress-develop that referenced this pull request Feb 1, 2023
The block editor's iframe needs to know if the theme is a block theme. This changeset adds a setting to `get_block_editor_settings()`.

Reference:
* WordPress/gutenberg#46212

Props ellatrix, alexstine, costdev, dgwyer, glendaviesnz, scruffian.
Fixes #57549.

git-svn-id: https://develop.svn.wordpress.org/trunk@55147 602fd350-edb4-49c9-b593-d223f7449a82
@bph bph mentioned this pull request Feb 6, 2023
47 tasks
VenusPR added a commit to VenusPR/Wordpress_Richard that referenced this pull request Mar 9, 2023
The block editor's iframe needs to know if the theme is a block theme. This changeset adds a setting to `get_block_editor_settings()`.

Reference:
* WordPress/gutenberg#46212

Props ellatrix, alexstine, costdev, dgwyer, glendaviesnz, scruffian.
Fixes #57549.
Built from https://develop.svn.wordpress.org/trunk@55147


git-svn-id: http://core.svn.wordpress.org/trunk@54680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@strarsis
Copy link
Contributor

@ellatrix: It appears that in latest WordPress core the Gutenberg editor now isolates the styles without CSS selector post-processing, just by injecting the styles into the iframe? So this iframe style isolation feature is used now?

@ellatrix
Copy link
Member Author

Right, we no longer scope the CSS because it's no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle
Projects
None yet