Shadow: Add option to unset shadow #47628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
added
the
Global Styles
|
Size Change: +20 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
I would favor something more like the designs we shared here. Specifically, to remove the shadow you remove the entire control by clicking the – icon.
What do you think? |
In following scenarios, a shadow isn't available for deletion and "Unset" might be required.
In these situations and explicit value |
|
Aren't all of those issues relevant to the design in this PR too? IE to remove an inherited shadow one would have to add a shadow locally, then choose the Feels like this is all a part of #43082. |
|
Agreed. The suggested solution should handle the above cases. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change introduces a new shadow option "Unset" along with the shadow presets, so that a specific block can remove the given shadow.
Why?
This option is required in scenarios such as
usetit.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
In the above UI, it is not obvious that the first choice is shadow "unset".
Adding tooltips might help. Need UX feedback @WordPress/gutenberg-design
Duotone UI for reference:
Related
Followup for #44651