Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page List: Performance: Improve page list callback #48004

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Page List: Performance: Improve page list callback #48004

merged 1 commit into from
Feb 13, 2023

Conversation

spacedmonkey
Copy link
Member

What?

In the render_block_core_page_list function use post object instead of id.

Related: #47997 #48001

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@spacedmonkey spacedmonkey self-assigned this Feb 13, 2023
@github-actions
Copy link

Flaky tests detected in 362f21f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4159393038
📝 Reported issues:

getdave
getdave approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I assume this is because using the object means it doesn't do the object look up again.

Seems like a solid change.

@spacedmonkey spacedmonkey merged commit 8d11d2b into trunk Feb 13, 2023
@spacedmonkey spacedmonkey deleted the fix/render_block_core_page_list branch February 13, 2023 10:41
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 13, 2023
@spacedmonkey spacedmonkey added [Type] Performance Related to performance efforts [Block] Page List Affects the Page List Block labels Feb 13, 2023
@DaisyOlsen DaisyOlsen added the [Package] Block library /packages/block-library label Feb 14, 2023
@DaisyOlsen DaisyOlsen changed the title Performance: Improve page list callback Page List: Performance: Improve page list callback Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getdave getdave getdave approved these changes

@adamziel adamziel Awaiting requested review from adamziel

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@glendaviesnz glendaviesnz Awaiting requested review from glendaviesnz

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@spacedmonkey spacedmonkey

Labels
[Block] Page List Affects the Page List Block [Package] Block library /packages/block-library [Type] Performance Related to performance efforts
Projects
None yet
Milestone
Gutenberg 15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@spacedmonkey @getdave @DaisyOlsen