Lodash: Refactor context system provider away from _.merge()
#48036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
mirka,
aristath,
noisysocks,
jsnajdr,
swissspidy,
ciampo,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +555 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4b0656a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4165992656
|
tyxla
force-pushed
the
refactor/context-system-provider-merge
branch
from
137e457
to
4b0656a
Compare
ciampo
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the
ContextSystemProvideraway from one of the last_.merge()usages. There is just a single use in that block and conversion is pretty straightforward.Similar to #47790.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing
_.merge()with the tinydeepmergelibrary, which works well as a drop-in replacement in my tests, and we've been using it in a few other places already (in@wordpress/datafor example).We're falling back to empty objects just in case we're dealing with a
nullorundefinedvalue - something that_.merge()handles internally, allowing gracefully returning empty objects even when passingnullorundefinedvalues.We're also using
isPlainObject()as a criteria for merging since that's how_.merge()works - that way it will deep merge objects like_.merge()did, but will override arrays, or other data types likeSet,Map, etc, again, mirroring the original behavior of_.merge().Last, but not least, we're intentionally removing the
JSON.parse( JSON.stringify() )trick, becausedeepmerge()will create a new object anyway.This uses a similar approach to #47790.
Testing Instructions
Testing Instructions for Keyboard
None.
Screenshots or screencast
None.