Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectors API: Rename Duotone parent from filters to filter #49360

Closed

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Moves duotone selectors under filter instead of the plural filters.

Why?

This is to help bring consistency between all the various locations for duotone e.g. theme.json, block supports, selectors etc. See #49340 for further context.

How?

  • Renames filters to filter
  • Updates the global function to retrieve block CSS selectors to request filter.duotone
  • Updates the tests for the global function
  • Updates theme.json class to request filter.duotone

Testing Instructions

  1. Ensure selectors tests pass: npm run test:unit:php -- --filter WP_Get_Block_CSS_Selector_Test
  2. To test manually you can check out Duotone: Update to use selectors API #49325 which will be updated to use filter.duotone as well and be based on this PR.

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Mar 27, 2023
@aaronrobertshaw aaronrobertshaw self-assigned this Mar 27, 2023
@aaronrobertshaw
Copy link
Contributor Author

Closing as these changes were absorbed into a single PR cleaning up the Selectors API (#49393).

@oandregal oandregal deleted the update/duotone-parent-in-selectors-api branch March 28, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant