[RNMobile] Update setup media picker helper #50398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
fluiddot
force-pushed
the
rnmobile/update/setup-media-picker
branch
from
c6c852e
to
ea21fd8
Compare
fluiddot
commented
May 8, 2023
Comment on lines
+50
to
+51
| url: url ?? localUrl, | ||
| id: id ?? localId, |
There was a problem hiding this comment.
Note that now if the media item has url and id properties, they will be used instead of local ones.
2 tasks
|
Flaky tests detected in b2d74c9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4937294018
|
fluiddot
force-pushed
the
rnmobile/update/setup-media-picker
branch
from
c10fb91
to
d0dba7f
Compare
fluiddot
commented
May 10, 2023
There was a problem hiding this comment.
This change has been approved via #50399 (review).
SiobhyB
approved these changes
May 10, 2023
There was a problem hiding this comment.
Tested via wordpress-mobile/gutenberg-mobile#5735 and confirm the changes look good to me. 👏 👏
fluiddot
force-pushed
the
rnmobile/update/setup-media-picker
branch
from
d0dba7f
to
b2d74c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the media picker helper to support more functionality.
Why?
This is needed for tests being worked on Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#5734.
How?
The following updates have been made:
multipleoption asfalse, when calling backmediaPickerCallbackit will return the media item instead of an array. This is needed for components that expect only an item to be returned.metadataproperty when notifying a succeeded upload.Testing Instructions
These changes can be tested via wordpress-mobile/gutenberg-mobile#5735. Specifically, this change is used here.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A