ColorPalette: Improve color name readability #50450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +211 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7435f08. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5080901975
|
chad1008
commented
May 10, 2023
|
👋 @jameskoster! Requesting your expert design input! I'm basing this PR on your recommended design. Initially I've set it up to only display the new section below the color picker button if a value is present... but I don't love how it pops in and out of view, making the popover's size change when a selection is made or cleared: Screen.Recording.2023-05-11.at.13.09.03.movWould it be better to make that new section always visible, even if it's empty when no value is selected? Something like this: Screen.Recording.2023-05-11.at.13.29.57.mov |
|
Thanks for the ping @chad1008, I agree the jumping is not ideal. There are a couple of options we might try... First of all we might hide the white 'details area' when the color is unset, but have the transparent texture occupy the same overall footprint. Similar to your second video just without the empty area. But I suspect that will give too much visual prominence to the texture. So perhaps this is an opportunity for us to communicate that the color is unset? In these cases, instead of the color name the label could be "No color set", and the 'value' could be "Transparent". This might even help a bit with #43082. For custom colors the label could be "Custom". What do you think? |
|
I love the idea of some default text for unselected values! My one concern with "Transparent" for unset values though would be that it won't always be accurate. When using I'd suggest we go with 'default' for now, to keep with the existing patterns mentioned in the issue you've linked. It has drawbacks, but if/when a more holistic solution is adopted we can revisit then. How does this look? 
|
|
That's a good point. In that case, I don't suppose the |
|
Perfect, thanks @jameskoster |
chad1008
force-pushed
the
colorpalette-layout-update
branch
from
ce694cb
to
f549a10
Compare
ciampo
reviewed
May 17, 2023
chad1008
commented
May 18, 2023
I definitely agree. The more I play with this component, the more that starts to bug me 😆. I don't think it's something the component can currently do, but I definitely want to defer to @mirka or @ciampo, as they've worked with it a lot longer than I have. From my understanding and work with it though, it would be dependent on the consumer passing an initial I could be wrong, but I think we might need a new prop to handle that, something like |
chad1008
removed request for
talldan,
gziolo,
swissspidy,
ntwb,
mmtr,
ryanwelcher,
nerrad,
adamsilverstein,
ndiego,
michalczaplinski,
dmsnell,
noahtallen,
ObliviousHarmony,
kevin940726,
tellthemachines,
fluiddot,
fabiankaegy and
t-hamano
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48119
What?
Improve readability of the color name and value by moving it off of the color swatch.
Why?
See #48119 for more context and conversation, but in short having the text overlayed over the currently selected color can create contrast issues that are difficult to navigate due to the number of variables. One of these is that selecting a text color that will contrast well with the checkered pattern used to represent transparencies is likely going to be very difficult.
How?
By moving the color name and value down below the swatch, contrast with the color itself and the transparency pattern are no longer a concern. The only contrast we'll need to worry about is the background color.
Notes
Testing Instructions
Testing Instructions for Keyboard
ColorPaletteopen in Storybook or the editor, pressTabonce to focus the picker button. Then pressEnter/Returnto select it.Escto close the popoverTabonce to confirm the focus moves to the firstCircleOptionPickeroption, confirming these changes don't alter the tab sequence.Screenshots