Fix: Can't type space if RichText component is inside button/summary in Firefox
#50540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Feature] Rich Text
|
Size Change: +67 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Interesting. I thought the fix could be applied to the details block itself. I'm maybe a little bit nervous about using |
|
Thanks for the advice. It appears that this issue is being actively attempted to be resolved in Firefox bug report.
If this issue is resolved in the latest version of Firefox, how do you feel about closing this PR as well, assuming #49679 is also resolved? |
|
I suppose it depends on how longer firefox users generally take to upgrade. I think the release cadence is monthly, so it might take a few months for users to shift over once the fix is merged. |
t-hamano
force-pushed
the
fix/firefox-editable-space
branch
from
c63efaf
to
744a466
Compare
|
I think I am ready for this PR.
Although it is not common, this problem also occurs outside of the Details block. For example, if you create a custom block and insert a RichText component inside a button/summary element. To avoid affecting other events (e.g., the event where a list is generated when a space is pressed after a hyphen), I have made it so that it is only processed when it is inside a button/summary element. |
|
@ellatrix |
|
I think it'd be good to get the details block out of its experimental status soon, as otherwise there's a risk of it not being ready in time for WordPress 6.3. Lets move ahead with merging this one, still plenty of time to change some things if needed after this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #49679
What?
This PR fixes a problem where a space could not be entered if there is a
RichTextcomponent in thebutton/summaryelement. In the core block, this can be reproduced with the summary element in the Details block.Why?
This is a Firefox-specific issue and has been reported in bug reports, as reported in this comment. In the future, this may be fixed in Firefox itself, but it should not be a problem to fix it in Gutenberg first.
How?
I have added an event to the RichText component hook that monitors keydowns. In this event, if the space key is pressed and in a button/summary element (which is the case that causes the problem), the default event is canceled and an explicit space is added.
Testing Instructions
Insert a Details block in the Firefox browser.
In the summary element, make sure you can type the space key.
Before
before.mp4
After
after.mp4