DropdownMenu v2: change default placement to match the legacy DropdownMenu component #51133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
ciampo
force-pushed
the
feat/dropdownmenu-v2-change-default-placement
branch
from
899bfb8
to
70352eb
Compare
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…nMenu component (WordPress#51133) * Update docs * CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #50459
What?
The legacy
DropdownMenucomponent shows its popover in thebottom-startplacement since it fallbacks to the default value of thePopovercomponent for itsplacementprop.This PR updates the default value of the
DropdownMenuv2 component to be the same as the legacyDropdownMenuWhy?
Consistency and less disruption when updating from legacy to v2
How?
Change default prop assignment, update docs
Testing Instructions
Open Storybook, notice how the popover of the
DropdownMenuv2 component is not opening against the edge of the viewport, but is instead aligned with the left side of the trigger button.Screenshots or screencast
(ignore the border styles)