List View: A11Y focus enhancements for edit-site based on modifications to edit-post #51404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstine
added
[Focus] Accessibility (a11y)
|
Size Change: +1.9 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 20f5008. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5237413260
|
|
Thanks for the ping, @alexstine. This is on my to-do list; I'll try to review/test it this week. |
jeryj
approved these changes
Jun 13, 2023
jeryj
approved these changes
Jun 13, 2023
alexstine
changed the title
|
For parity sake, I wonder if we should eventually rename the edit-site list view to document overview. Seems confusing to have two different things although the list view in edit-site is really just a list view of blocks. Might be worth an issue to discuss. |
I haven't ever worked with it. Does it seem like it could be combined into one? Or is there too much divergence between them? I agree that it would be great if it was just a way of navigating any list of blocks in the editor. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ns to edit-post (WordPress#51404) * Bring A11Y changes to site editor list view from the post editor. Add E2E testing. * Add missing comment to explain usage of open-only keyboard shortcut usage. * Reviewer feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The document overview sidebar in the edit-post package has had focus enhancements for accessibility for some time now. Time to bring those over to edit-site.
Why?
Improves the usefulness of the document overview shortcut. When the sidebar is closed, it opens the sidebar. When the sidebar is opened and focus is inside the sidebar, the sidebar closes. If the sidebar is opened and focus is outside the sidebar, focus will be brought back to the sidebar.
How?
Implements similar code already written for the edit-post package. Added a modified E2E test to site-editor.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast