Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Display custom color value in mobile Cover Block color picker #51414

Merged
merged 13 commits into from
Aug 3, 2023
Merged

[RNMobile] Display custom color value in mobile Cover Block color picker #51414

merged 13 commits into from
Aug 3, 2023

Commits on Jun 12, 2023

  1. Display custom color value in mobile color picker

    @derekblank
    derekblank committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    697c7ff View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Update Cover block bottomLabelText to use proper hex color style

    @derekblank
    derekblank committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    41f0c71 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Update text color style

    @derekblank
    derekblank committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a7208e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Merge remote-tracking branch 'origin' into rnmobile/display-value-in-… 

    …colorpicker
    @derekblank
    derekblank committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    7675bb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Update CHANGELOG

    @derekblank
    derekblank committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    577610d View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Merge trunk and update RELEASE-NOTES

    @derekblank
    derekblank committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    1371f35 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Update getBottomLabelText from a function to a const

    @derekblank
    derekblank committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9b9d985 View commit details
    Browse the repository at this point in the history

  2. Add test for Cover block custom color picker

    @derekblank
    derekblank committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    5f7d22f View commit details
    Browse the repository at this point in the history

  3. Merge trunk

    @derekblank
    derekblank committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    e9b427e View commit details
    Browse the repository at this point in the history

  4. Update Cover block color picker test

    @derekblank
    derekblank committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    04c5075 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. test: Fix Cover block color picker test (#52943) 

    * test: Mock required styles for Cover block tests

JavaScript logic fails due to undefined references from mocked Sass
files.

* test: Fix Cover block HEX test assertions

Synchronous queries of user-facing text is generally preferred over test
IDs or asynchronous queries. Additionally, the
`react-native-hsv-color-picker` must be mocked to trigger the required
interaction events. Lastly, selecting the white color results in a
non-custom color, which does not appear to display the HEX value in the
picker footer label.
    @dcalhoun
    dcalhoun committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    81abcec View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Merge branch 'trunk' into rnmobile/display-value-in-colorpicker

    @derekblank
    derekblank committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0cf3830 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Merge branch 'trunk' into rnmobile/display-value-in-colorpicker

    @derekblank
    derekblank committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    da3b085 View commit details
    Browse the repository at this point in the history