Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: fix closing when contained iframe is focused #51602

Merged
merged 16 commits into from
Oct 5, 2023
Merged

Modal: fix closing when contained iframe is focused #51602

merged 16 commits into from
Oct 5, 2023

Commits on Oct 5, 2023

  1. Fix modal closing when a contained iframe is focused 

    Remove focus outside hook.
    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    35ab7cc View commit details
    Browse the repository at this point in the history

  2. Test: add iframe to Modal component

    @t-hamano @stokesman
    t-hamano authored and stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6502514 View commit details
    Browse the repository at this point in the history

  3. Monopolize open modal

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    22d4171 View commit details
    Browse the repository at this point in the history

  4. Revise comment

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    40ae7fe View commit details
    Browse the repository at this point in the history

  5. Remove needless condition

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8eae8b3 View commit details
    Browse the repository at this point in the history

  6. Avoid running effect due to unstable prop

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e76f873 View commit details
    Browse the repository at this point in the history

  7. Permit nested Modals

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    517cdb1 View commit details
    Browse the repository at this point in the history

  8. Robustly support nested Modals

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1bf1f02 View commit details
    Browse the repository at this point in the history

  9. Preserve current behavior for nested modals

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    f4344d3 View commit details
    Browse the repository at this point in the history

  10. Split effect to separate concerns

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    795d2c5 View commit details
    Browse the repository at this point in the history

  11. Add unit test for request closing of nested modals

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    49f95b3 View commit details
    Browse the repository at this point in the history

  12. Call onRequestClose for nested modal when outer modal unmounts

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    183b9a3 View commit details
    Browse the repository at this point in the history

  13. Comment and rename per feedback

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    145dc0e View commit details
    Browse the repository at this point in the history

  14. Add changelog entry

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    04a1194 View commit details
    Browse the repository at this point in the history

  15. Revert "Test: add iframe to Modal component" 

    This reverts commit 6502514.
    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3c18cfe View commit details
    Browse the repository at this point in the history

  16. Fix changelog

    @stokesman
    stokesman committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c7824d6 View commit details
    Browse the repository at this point in the history