Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: fix error with react list key with new custom patterns list in inserter #51877

Closed
wants to merge 5 commits into from
Closed

Patterns: fix error with react list key with new custom patterns list in inserter #51877

wants to merge 5 commits into from
+73 −34

Commits on Jun 25, 2023

  1. Fix error with react list key with new custom patterns list in inserter

    @glendaviesnz
    glendaviesnz committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    b5ab3ff View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Update placeholder key

    @glendaviesnz
    glendaviesnz committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    1ff9a39 View commit details
    Browse the repository at this point in the history

  2. Add comment to explain the different keys

    @glendaviesnz
    glendaviesnz committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8d73990 View commit details
    Browse the repository at this point in the history

  3. Patterns: Fix missing custom patterns in patterns explorer (#51889) 

    * Add custom patterns to pattern explorer

* show custom patterns in the patterns explorer dialog

* remove changes from 51877

* Fix up use of async lists

* remove a bit of code duplication by adding a new hook

* add 51877 fix back to make testing easier
    @glendaviesnz
    glendaviesnz committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5695beb View commit details
    Browse the repository at this point in the history

  4. Just assign the key value in one place

    @glendaviesnz
    glendaviesnz committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    87a8812 View commit details
    Browse the repository at this point in the history