Fix: enable link editing interface when removing Draft links #52528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanales
added
[Type] Bug
|
Size Change: +24 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d46234d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5524003800
|
getdave
requested changes
Jul 12, 2023
|
Thank you for taking the time to raise this PR. Ultimately I ended up approved #52415 because I felt it's a better approach and I"d rather avoid any more props being added to Feel free to close if you think that's ok? 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #50180
Handling a special case in which links to Draft pages in the Navigation Block fail to complete the link removal flow, incorrectly displaying an empty Link Preview.
How?
Uses
forceIsEditingLinkon theLinkControlto enable or disable the link editing UI depending on whether or not the page was a Draft. If the page is not a Draft, default behavior is unaffected.Testing Instructions
Within the navigation block.