[Mobile] Update media placeholders and block outline #52702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
2 tasks
|
Size Change: +46 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
SiobhyB
approved these changes
Jul 18, 2023
packages/block-editor/src/components/media-placeholder/styles.native.scss
Show resolved
Hide resolved
|
Hey @SiobhyB 👋 thanks for reviewing and testing! I've added a couple of commits after your initial review:
|
|
Flaky tests detected in ad16a7a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5597559323
|
|
@geriux, perfect, thank you for following up! I reviewed and tested the most recent changes |
🚀
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR brings back the BlockOutline that was removed in #51222 and also updates the MediaPlaceholder with new styles.
Why?
To prevent confusion of selected states of blocks and also to improve our current editor UI.
How?
It restores the
BlockOutlinecomponent and updates its logic so the outline will be shown when the component is selected and meets one of the following conditions: it is atextblock with inner blocks, it is a block other thantextwith inner blocks and is at root list level, or it is a block other thantextwith inner blocks and is not at root list level.New colors were added
$blue-60,$blue-40and$dark-dim.MediaPlaceholder
Updates the component so it can be selected before the whole container had a touch action so it wouldn't be possible to be in a selected state.
Now a button will be shown in the middle to allow users to upload media, it also updates the styles and cleans up the code a bit.
Embed Placeholder
It brings the same style modifications from the MediaPlaceholder component to this one.
Tests
General snapshot updates and integration tests were updated after these changes.
Testing Instructions
Test case 1
Test case 2
Test case 3
Testing Instructions for Keyboard
N/A
Screenshots or screencast
iOSChanges.mov
AndroidChanges.mov