Added Color Selection Option for FootNote Block #52918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghorivipul97
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Should also add support for link color as well; so that the footnote link can be colorized. 
|
|
Actually, I just saw this PR (#52897) was merged an hour ago with this feature already implemented. Thanks for the PR but I'll close in lieu of that. You could explore other dimensions controls perhaps; like padding and margin (off by default). |
|
Thanks for working on this @ghorivipul97, but this PR can be closed. @mikachan already tackled this here: #52897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added Color Selection Option for FootNote Block
Why?
#51991
How?
Allow Color Selection for block