-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Reset current page when search filters change #52933
Patterns: Reset current page when search filters change #52933
Conversation
Size Change: +322 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
The console error thrown due to hooks running after DOM elements have been removed will be addressed via a separate PR. I've updated the PR description to match. |
The error and crash while searching filtered patterns has been fixed in #52956. I think we are right to move forward with landing this fix as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well for me, always returned to page 1 when toggling the sync status or updating the search term.
Hi folks. I just tried to cherry pick this PR to: But it relies on code in trunk that has not yet been merged to the wp/6.3 branch, e.g., code from #52663 So I had to leave it out. |
Fixes: #52926
What?
Resets the current page of pattern results when search term or sync status filters are updated to ensure results are shown.
Why?
Searching patterns isn't much use if it can only be done on the first page of results.
How?
Resets the current page state when search term or filters change.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-07-26.at.9.06.18.am.mp4