Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore local test theme folders created by wp-env #53031

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

WunderBart
Copy link
Member

What?

Add test themes folders created by wp-env to .gitignore so they're ignored by linter.

Why?

Because wp-env creates these folders with very restrictive permissions and they have to be removed by a root user to make the commit linter pass.

image

Testing Instructions

  • Run npx wp-env start --update - you should see twentytwentyone and twentytwentythree be downloaded and installed as per this config.
  • Confirm that the above theme folders have been created inside /test/gutenberg-test-themes/ folder (they should be empty).
  • Make any change to any file and try to commit it - you should be able to do this without the aforementioned issue on this branch and not on trunk.

@WunderBart WunderBart self-assigned this Jul 27, 2023
@WunderBart WunderBart marked this pull request as ready for review July 27, 2023 13:29
@tyxla tyxla added the [Type] Enhancement A suggestion for improvement. label Jul 27, 2023
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just encountered this - great timing!

Thanks for fixing 🚀

@github-actions
Copy link

Flaky tests detected in b7bc7a7.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5681175779
📝 Reported issues:

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as well. Thank you!

@WunderBart WunderBart merged commit 94381c2 into trunk Jul 27, 2023
52 checks passed
@WunderBart WunderBart deleted the fix/test-themes-folder-permissions branch July 27, 2023 16:29
@github-actions github-actions bot added this to the Gutenberg 16.4 milestone Jul 27, 2023
@mikachan mikachan added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] E2E Tests /packages/e2e-tests and removed [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Tests /packages/e2e-tests [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants