Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Note the preios setup script #53312

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Aug 3, 2023

What?

Document the need to run npm run native preios when setting up the native
editor development environment.

Why?

Without running this command, the iOS app will not successfully build as
Pod dependencies will be missing. The native preios script is run by
the native ios script, but it is possible to build the iOS app through
other means that do not run native preios, e.g. pressing i after
starting the Metro server via npm run native start:reset.

Explicitly running preios during setup will help avoid confusing
errors.

metro-server-commands

How?

Add a note to the getting started documentation.

Testing Instructions

n/a

Testing Instructions for Keyboard

n/a

Screenshots or screencast

n/a

Without running this command, the iOS app will not successfully build as
Pod dependencies will be missing. The `native preios` script is run by
the `native ios` script, but it is possible to build the iOS app through
other means that do not run `native preios`, e.g. pressing `i` after
starting the Metro server via `npm run native start:reset`.

Explicitly running `preios` during setup will help avoid confusing
errors.
@dcalhoun dcalhoun added [Type] Developer Documentation Documentation for developers Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Aug 3, 2023
@dcalhoun dcalhoun self-assigned this Aug 3, 2023
@dcalhoun dcalhoun enabled auto-merge (squash) August 3, 2023 20:47
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 ! Thanks @dcalhoun for updating the documentation 🙇 !

@dcalhoun dcalhoun merged commit 284455b into trunk Aug 4, 2023
53 checks passed
@dcalhoun dcalhoun deleted the docs/note-pre-ios-setup-script branch August 4, 2023 13:11
@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants