Add children back to toolbar item render for rendered components

[joshuatf]

What?

Fixes #53313
Allows usage of children for toolbar item components that make use of the as prop.

Why?

This was removed in #51623. I believe this was unintentional and missed as a test case since many of the ToolbarItems take advantage of icon or label props, but pinging @diegohaz to confirm that there are no other issues with doing this with the newer Ariakit implementation.

How?

This PR simply reverts to passing children to BaseToolbarItem so they can be used by the passed component in render.

Testing Instructions

1. Add a component that uses both the as property and children:

<ToolbarItem
	as={ Button }
	variant="primary"
	onClick={ doSomething }
>
	This text should show
</ToolbarItem>

2. Verify that the text is shown in the toolbar button
3. Check other toolbar items around the site to make sure no regressions have occurred

Optionally, to see a real-world use case where this was broken:

1. Install WooCommerce 8.0 RC-1 - https://github.com/woocommerce/woocommerce/releases/tag/8.0.0-rc.1
2. Use the latest GB and/or WP 6.3.
3. Enable the new product editing experience under WooCommerce -> Settings -> Advanced -> Features.
4. Navigate to the Add Product page.
5. Click on "Add description"
6. Note that the "Cancel" and "Done" buttons and text are visible in the modal toolbar.

Testing Instructions for Keyboard

Screenshots or screencast

Before

After

[tyxla]

Thanks for diagnosing it and working to address it @joshuatf 🙌

I agree with @diegohaz that it feels best to actually pass children to the Component instance of the render prop, either the way Diego suggested, or as a children prop to the Component instance.

[ciampo]

Hey @joshuatf , just checking if you have the capacity to wrap up this PR :)

[ciampo]

Hey @tyxla and @diegohaz , would you mind giving this PR one last look? I took over, rebased, and addressed feedback.

Thank you!

[ciampo]

For some some prettier wasn't working properly on my machine — that should be fixed now.

[tyxla]

LGTM 🚀

[github-actions]

Flaky tests detected in c741395.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6158166746
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js