Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Horizontal rule accepts style extensions #53917

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix: Horizontal rule accepts style extensions #53917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
173b498
fix: Horizontal rule accepts style extensions
dcalhoun Aug 24, 2023
c25d254
docs: Add change log entry
dcalhoun Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/primitives/src/horizontal-rule/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,18 @@ const HR = ( {
lineStyle,
marginLeft,
marginRight,
style,
textStyle,
text,
...props
} ) => {
const renderLine = ( key ) => (
<View
key={ key }
style={ getStylesFromColorScheme( styles.line, styles.lineDark ) }
style={ [
getStylesFromColorScheme( styles.line, styles.lineDark ),
lineStyle,
] }
/>
);

Expand All @@ -44,11 +48,7 @@ const HR = ( {

return (
<View
style={ [
styles.container,
{ marginLeft, marginRight },
props.style,
] }
style={ [ styles.container, { marginLeft, marginRight }, style ] }
{ ...props }
>
{ renderInner() }
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ For each user feature we should also add a importance categorization label to i
## Unreleased
- [*] Search Control - Prevent calling TextInput's methods when undefined [#53745]
- [*] Improve horizontal rule styles to avoid invisible lines [#53883]
- [*] Fix horizontal rule style extensions [#53917]

## 1.102.0
- [*] Display custom color value in mobile Cover Block color picker [#51414]
Expand Down
Loading