Font Library: Font Collection backend #54097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Release script: Update react-native-editor version to 1.101.0 * Release script: Update with changes from 'npm run core preios' * Update `react-native-editor` CHANGELOG * Remove incorrect CHANGELOG entry The iOS focus loop will be included in 1.100.2. I've updated the CHANGELOG accordingly. * Release script: Update react-native-editor version to 1.101.1 * Release script: Update with changes from '$PRE_IOS_COMMAND' * fix: Dynamic bottom sheet height (#53608) Stretching this content with flex appears to be necessary after upgrading React Native or refactoring the bottom sheet height animation. Refactor: 0411df1 Upgrade: c2957aa * fix: Optional chaining to handle undefined title (#53721) This PR adds safety checks for the `title` property within `reusableBlock`. By using optional chaining, the code now gracefully handles scenarios where `title` might be undefined, preventing a TypeError from being thrown. * Update CHANGELOG * Release script: Update react-native-editor version to 1.101.2 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Fix Voice Over and assistive keyboards (#53895) * AztecView - Replace usage of TouchableWithoutFeedback with Pressable - This fixes the current React Native regression with VoiceOver and assistive keyboards * Patch React Native's TextInput component to avoid passing the recently introduced accessibilityState prop which causes issues with assistive keyboards * Updates snapshots: Fule, Audio blocks and Search component after changing the AztecView component to use Pressable * Update AztecView's Pressable with changing its accessible prop to false * Update Changelog --------- Co-authored-by: Siobhan <siobhan@automattic.com> Co-authored-by: David Calhoun <github@davidcalhoun.me> Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
* Overwriting wp-date script string to include new relateTime translations * Making the translator comments clearer because some languages change the case of indefinite articles * LINTY LINTY SPACEY SPACEY * comma comma comma comma comma chameleon * Move global inside check * Remove useless assignment * It's better to add this to lib/compat/wordpress-6.4/script-loader.php as it reflects the intended destination in Core and also communicates compatibility.
…cker (#53329) * Add hsv color picker components * Update Saturation Picker from source * Update Hue Picker from source * Update hsv-color-picker imports * Remove third-party dependency package react-native-hsv-color-picker * Update hsv-color-picker styles * Update CHANGELOG * Add tinycolor2 package * Remove dependency on tinycolor2 from hsv-color-picker * Remove tinycolor package reference * Revert empty change on initial editor html * Update hsv-color-picker container style * Add color-picker integration test * Update packages/components/src/color-picker/style.native.scss Co-authored-by: David Calhoun <github@davidcalhoun.me> * Update packages/react-native-editor/CHANGELOG.md Co-authored-by: David Calhoun <github@davidcalhoun.me> * Update Color Picker code style and test formatting * Update hsv-color-picker test ID * Remove color picker test Removes Color Picker test in favor of testing the color picker in a deeper editor tree, like Cover block * Update saturation picker imports --------- Co-authored-by: David Calhoun <github@davidcalhoun.me>
* Add attribute & context „midSize“ to pagination block. * Add and use QueryPaginationMidSizeControl in PaginationBlock. * React to new „midSize“ context in pagination numbers block. * Adjust unit tests. * Fix php errors from partial line commits. * Remove unneeded React import. * Move midSize control to query pagination numbers * Fix incorrect partial php commit * Get midSize param from attributes not context * Re-add missing array definition line * Update help description. * Remove unnecessary formatting changes * Fix formatting issue. * Move mid size control from own file into edit.js * Only pass mid_size if set; also for inherit query * Fix space alignment * Increase last pagination number to justify … gap * Rebuild test
…53733) * Add router with region-based client-side navigation * Add changelog * Interactivity API: merge new server-side rendered context on client-side navigation (#53853) * Add failing test * Fix the test * Add changelog * Fix lint error * Fix changelog placement * Interactivity API: Support for the `data-wp-key` directive (#53844) * Add failing test * Fix test using key * Replace key with data-wp-key * Refactor test a bit * Add changelog * Add docs * Remove unnecessary paragraph * Fix lint error * Interactivity API: Fix non stable context reference on client side navigation (#53876) * Add failing test * Fix the test * Refactor addPostWithBlock util * Add tests for router regions --------- Co-authored-by: David Arenas <david.arenas@automattic.com>
* Icons: Fix invalid XML namespace * Update CHANGELOG.md
* Release script: Update react-native-editor version to 1.102.0 * Release script: Update with changes from 'npm run core preios' * Bump version in package-lock.json * Update CHANGELOG to reflect latest release * Fix PR reference in CHANGELOG entry * Release script: Update react-native-editor version to 1.102.1 * Release script: Update with changes from 'npm run core preios' * [Mobile] - Fix Voice Over and assistive keyboards (#53895) * AztecView - Replace usage of TouchableWithoutFeedback with Pressable - This fixes the current React Native regression with VoiceOver and assistive keyboards * Patch React Native's TextInput component to avoid passing the recently introduced accessibilityState prop which causes issues with assistive keyboards * Updates snapshots: Fule, Audio blocks and Search component after changing the AztecView component to use Pressable * Update AztecView's Pressable with changing its accessible prop to false * docs: Add change log entry --------- Co-authored-by: Gio Lodi <gio@mokacoding.com> Co-authored-by: Siobhan <siobhan@automattic.com> Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
* Add undefined and null to the removeAttribute This should be done in a separate PR. * Adding first test cases (WIP) * Add comment * Remove unnecessary comment * Update test cases * Fix bind useEffect logic * Update changelog * Add type and comments to matrix entries * Fix phpcs errors --------- Co-authored-by: Luis Herranz <luisherranz@gmail.com>
* Add undefined and null to the removeAttribute This should be done in a separate PR. * Adding first test cases (WIP) * Add comment * Remove unnecessary comment * Update test cases * Fix bind useEffect logic * Update changelog * Add type and comments to matrix entries * Fix phpcs errors * Copy current implementation * Refactor data-wp-slot * Add slot and fill tests * Add changelog * Fix changelog --------- Co-authored-by: Luis Herranz <luisherranz@gmail.com>
Add a new panel (tentatively named "Plugins") to the block inspector that lists blocks that are slated for auto-insertion next to that block, and provide toggles to insert (or remove) them. Co-authored-by: Carlos Bravo <carlos.bravo@automattic.com>
* test: Remove duplicative tests These are covered by: `packages/block-library/src/social-links/test/edit.native.js` * test: Social Links sets a link URL Assert the fundamental functionality of setting a URL for a Social Link link.
* test: Export Social Icons block name Enable e2e tests for the Social Icons block by reference. * refactor: Log local Appium server start status Mitigate confusion regarding the local Appium server status.
…ng problematic workaround (#49904) * Use global main query directly so that global query loop works as expected. * Remove hack to enforce query loop as it causes problems, and the loop needs to be handled in block templates instead. * Maintain fix from #43198. * Clarify logic with comment. * Add test coverage.
* Don't show the preview options button when editing patterns * Refactor with FOCUSABLE_ENTITIES * Use disabled view icon * Use isEnabled prop * Also set 'disableOpenOnArrowDown' * Fix e2e test * Use `toBeDisabled` --------- Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
* PaletteEdit: Fix item height * Update CHANGELOG.md
* Add router with region-based client-side navigation * Add changelog * Initial version working * Only add supports.interactivity and enqueue the view.js file if the "Enhanced Pagination" option is enabled * Interactivity API: merge new server-side rendered context on client-side navigation (#53853) * Add failing test * Fix the test * Add changelog * Fix lint error * Fix changelog placement * Interactivity API: Support for the `data-wp-key` directive (#53844) * Add failing test * Fix test using key * Replace key with data-wp-key * Refactor test a bit * Add changelog * Add docs * Remove unnecessary paragraph * Fix lint error * Interactivity API: Fix non stable context reference on client side navigation (#53876) * Add failing test * Fix the test * Add basic accessibility (announcement + focus) * Add basic loading animation Co-authored-by: David Arenas <darerodz@users.noreply.github.com> * Only enqueue styles if they are needed * Add missing CSS props on aria-live element Apparently, some screen readers don't read elements that don't have width and height. * Fix two typos * Update fixture * Simplify loaded text * Move navigation announce style to a class --------- Co-authored-by: David Arenas <darerodz@users.noreply.github.com> Co-authored-by: David Arenas <david.arenas@automattic.com>
* Do not accept undefined start/end properties in RichTextValue * Accept null value to WPFormat
…54011) * Update native block outline component to outline all social-link blocks * Remove unneeded container style prop * Update CHANGELOG
… end of the document (#53859) * BlockList: Ensure element styles are always output at the end of the document * Remove hidden attribute so that Duotone still works in FF
matiasbenedetto
requested review from
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
peterwilsoncc,
kevin940726,
Mamaduka,
ntwb,
nerrad,
ryanwelcher,
luisherranz,
DAreRodz,
noisysocks,
draganescu,
tellthemachines,
adamziel,
getdave,
dmsnell,
atimmer,
mmtr,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
3 similar comments
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.4/script-loader.php ❔ lib/block-supports/colors.php ❔ lib/block-supports/elements.php ❔ lib/experimental/auto-inserting-blocks.php ❔ lib/experimental/editor-settings.php ❔ lib/load.php ❔ phpunit/blocks/render-post-template-test.php |
|
Size Change: +2.25 kB (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add extensibility capabilities to the Font Library.
Provides a way to provide collections of typographic fonts by code.
Why?
Example:
This is all the code required to create a plugin providing a font collection.
Download the plugin as zip ready to test:
my-font-collection.zip
How?
WP_Font_Collectionclass.wp_register_font_collectionfilter./fonts/collectionsandfonts/collections/<id>endpoints.To do
We would need this: WP_Theme_JSON sanitization is not working below certain level of theme.json #52798
Tracking issue:
Stage 1: #52698
Stage 2: #53307