Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List View: Try directing focus to the list view toggle button when closing the list view #54175

Merged
merged 6 commits into from
Sep 20, 2023
Merged

List View: Try directing focus to the list view toggle button when closing the list view #54175

merged 6 commits into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. List View: Try directing focus to the list view toggle button when cl… 

    …osing the list view
    @andrewserong
    andrewserong committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8840bd1 View commit details
    Browse the repository at this point in the history

  2. Only focus if no blocks are selected

    @andrewserong
    andrewserong committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c3216b2 View commit details
    Browse the repository at this point in the history

  3. Also use focus logic for when the list view is closed via the keyboar… 

    …d shortcut
    @andrewserong
    andrewserong committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e8271c0 View commit details
    Browse the repository at this point in the history

  4. Try implementing in the site editor, too

    @andrewserong
    andrewserong committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    53f0a7f View commit details
    Browse the repository at this point in the history

  5. Always return focus to the toggle whenever the list view is closed, r… 

    …oll out to widgets editor
    @andrewserong
    andrewserong committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5175627 View commit details
    Browse the repository at this point in the history

  6. Update e2e tests

    @andrewserong
    andrewserong committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    22f6851 View commit details
    Browse the repository at this point in the history